IGNITE-28432 Add storage name to segstore#7953
Merged
sashapolo merged 1 commit intoapache:mainfrom Apr 8, 2026
Merged
Conversation
ibessonov
approved these changes
Apr 8, 2026
There was a problem hiding this comment.
Pull request overview
Adds a distinct “storage name” dimension to segstore’s on-disk layout and background thread naming so multiple segstore instances can coexist more cleanly and be easier to identify operationally.
Changes:
- Extend
SegmentFileManagerto takestorageNameand place segments/indexes underbaseDir/<storageName>/.... - Include
storageNamein segstore GC/checkpointer thread names and in SegmentFileManager startup logging. - Update segstore-related tests to pass the new constructor parameter(s).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/segstore/SegmentFileManager.java | Introduces storageName, changes directory layout to be storage-scoped, and updates logging/initialization accordingly. |
| modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/segstore/RaftLogGarbageCollector.java | Adds storageName to the GC thread name for per-storage identification. |
| modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/segstore/RaftLogCheckpointer.java | Adds storageName to the checkpoint thread name for per-storage identification. |
| modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/SegstoreLogStorageTest.java | Updates SegmentFileManager construction to pass storageName. |
| modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/SegstoreLogStorageConcurrencyTest.java | Updates SegmentFileManager construction to pass storageName. |
| modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/SegmentFileManagerTest.java | Updates helper to construct SegmentFileManager with storageName. |
| modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/SegmentFileManagerGetEntryTest.java | Updates SegmentFileManager construction to pass storageName. |
| modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/RaftLogGcSoftLimitTest.java | Updates SegmentFileManager construction to pass storageName. |
| modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/RaftLogGarbageCollectorTest.java | Updates SegmentFileManager construction to pass storageName. |
| modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/RaftLogCheckpointerTest.java | Updates RaftLogCheckpointer construction to pass storageName. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-28432
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes