Skip to content

IGNITE-28432 Add storage name to segstore#7953

Merged
sashapolo merged 1 commit intoapache:mainfrom
gridgain:ignite-28432
Apr 8, 2026
Merged

IGNITE-28432 Add storage name to segstore#7953
sashapolo merged 1 commit intoapache:mainfrom
gridgain:ignite-28432

Conversation

@sashapolo
Copy link
Copy Markdown
Contributor

https://issues.apache.org/jira/browse/IGNITE-28432

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

Copilot AI review requested due to automatic review settings April 8, 2026 08:12
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a distinct “storage name” dimension to segstore’s on-disk layout and background thread naming so multiple segstore instances can coexist more cleanly and be easier to identify operationally.

Changes:

  • Extend SegmentFileManager to take storageName and place segments/indexes under baseDir/<storageName>/....
  • Include storageName in segstore GC/checkpointer thread names and in SegmentFileManager startup logging.
  • Update segstore-related tests to pass the new constructor parameter(s).

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/segstore/SegmentFileManager.java Introduces storageName, changes directory layout to be storage-scoped, and updates logging/initialization accordingly.
modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/segstore/RaftLogGarbageCollector.java Adds storageName to the GC thread name for per-storage identification.
modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/segstore/RaftLogCheckpointer.java Adds storageName to the checkpoint thread name for per-storage identification.
modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/SegstoreLogStorageTest.java Updates SegmentFileManager construction to pass storageName.
modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/SegstoreLogStorageConcurrencyTest.java Updates SegmentFileManager construction to pass storageName.
modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/SegmentFileManagerTest.java Updates helper to construct SegmentFileManager with storageName.
modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/SegmentFileManagerGetEntryTest.java Updates SegmentFileManager construction to pass storageName.
modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/RaftLogGcSoftLimitTest.java Updates SegmentFileManager construction to pass storageName.
modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/RaftLogGarbageCollectorTest.java Updates SegmentFileManager construction to pass storageName.
modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/RaftLogCheckpointerTest.java Updates RaftLogCheckpointer construction to pass storageName.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sashapolo sashapolo merged commit 7894034 into apache:main Apr 8, 2026
5 checks passed
@sashapolo sashapolo deleted the ignite-28432 branch April 8, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants