IGNITE-14382 Rework network module API structure #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashapolo
force-pushed
the
ignite-14382
branch
8 times, most recently
from
8728335 to
f25821a
Compare
modules/network/src/main/java/org/apache/ignite/network/Network.java
Outdated
Show resolved
Hide resolved
sergey-chugunov-1985
requested changes
Apr 6, 2021
Contributor
sergey-chugunov-1985
left a comment
sergey-chugunov-1985
left a comment
There was a problem hiding this comment.
I left a minor comment with naming suggestion.
sashapolo
force-pushed
the
ignite-14382
branch
2 times, most recently
from
77ddca5 to
ad4e183
Compare
AMashenkov
requested changes
Apr 9, 2021
...les/network/src/main/java/org/apache/ignite/network/scalecube/ScaleCubeMessagingService.java
Outdated
Show resolved
Hide resolved
...les/network/src/main/java/org/apache/ignite/network/scalecube/ScaleCubeMessagingService.java
Outdated
Show resolved
Hide resolved
...les/network/src/main/java/org/apache/ignite/network/scalecube/ScaleCubeMessagingService.java
Outdated
Show resolved
Hide resolved
...les/network/src/main/java/org/apache/ignite/network/scalecube/ScaleCubeMessagingService.java
Outdated
Show resolved
Hide resolved
AMashenkov
approved these changes
Apr 9, 2021
| /** {@inheritDoc} */ | ||
| @Override public void addMessageHandler(NetworkMessageHandler handler) { | ||
| messageHandlers.add(handler); | ||
| } |
Contributor
There was a problem hiding this comment.
We need a way to unregister message handlers for dynamically started components.
Contributor
Author
There was a problem hiding this comment.
Can you elaborate on the use cases please, because I may be out of context for this suggestion?
Contributor
There was a problem hiding this comment.
Some components (like a cache) can start/stop dynamically and should have possibility to deregister related listeners on stop.
I'm ok to implement this as a separate ticket.
Contributor
Author
There was a problem hiding this comment.
modules/network/src/main/java/org/apache/ignite/network/AbstractTopologyService.java
Show resolved
Hide resolved
modules/network/src/main/java/org/apache/ignite/network/ClusterLocalConfiguration.java
Outdated
Show resolved
Hide resolved
modules/network/src/main/java/org/apache/ignite/network/ClusterService.java
Outdated
Show resolved
Hide resolved
modules/network/src/main/java/org/apache/ignite/network/ClusterService.java
Outdated
Show resolved
Hide resolved
modules/network/src/main/java/org/apache/ignite/network/ClusterService.java
Outdated
Show resolved
Hide resolved
modules/network/src/main/java/org/apache/ignite/network/scalecube/ScaleCubeMemberResolver.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.