IGNITE-14536 Handle forceful shutdown of ScaleCube cluster node. #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashapolo
requested changes
Apr 14, 2021
modules/network/src/main/java/org/apache/ignite/network/scalecube/ScaleCubeTopologyService.java
Outdated
Show resolved
Hide resolved
...ntegrationTest/java/org/apache/ignite/network/scalecube/ITScaleCubeNetworkMessagingTest.java
Outdated
Show resolved
Hide resolved
| } | ||
| }) | ||
| .config(opts -> opts.memberAlias(context.getName())) | ||
| .config(opts -> opts.memberAlias(context.getName()).membership(config -> config.suspicionMult(1))) |
Contributor
There was a problem hiding this comment.
please add a comment that this timeout value is currently needed for tests
Contributor
There was a problem hiding this comment.
also, please move the multiplier configuration to the membership configuration on line 57
Contributor
Author
There was a problem hiding this comment.
Why tho? TODO in class def already states that it would be changed
Contributor
There was a problem hiding this comment.
yeah, maybe it's not really needed after all =)
modules/network/src/main/java/org/apache/ignite/network/scalecube/ScaleCubeTopologyService.java
Outdated
Show resolved
Hide resolved
sashapolo
approved these changes
Apr 15, 2021
asfgit
pushed a commit
that referenced
this pull request
Apr 19, 2021
…ful shutdown (#94) Signed-off-by: Sergey Chugunov <sergey.chugunov@gmail.com>
ygerzhedovich
pushed a commit
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.