IGNITE-16665 Introduced integer table id. #952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
tkalkirill
reviewed
Jul 22, 2022
| @Immutable | ||
| @Range(min = 1, max = Integer.MAX_VALUE) | ||
| @Value(hasDefault = true) | ||
| public int intId = 1; |
Contributor
There was a problem hiding this comment.
Why such a name? seems to be more correct just id.
Why such a range?
Can we use UUID as an identifier?
Contributor
Author
There was a problem hiding this comment.
UUID is already a main "globally unique" identifier. This one - I'm not sure about the name, honestly. Field named "id" already exists.
| public class TablesConfigurationSchema { | ||
| /** Global integer id counter. */ | ||
| @Value(hasDefault = true) | ||
| public int globalIdCounter = 0; |
Contributor
There was a problem hiding this comment.
Is this the global table identifier? why is it not clearly named? what happens if it overflows?
Contributor
Author
There was a problem hiding this comment.
I'l expand the comment
| * @param grpName Group name. | ||
| * @param grpId Group ID. | ||
| * @param tableName Table name. | ||
| * @param groupId Integer table id. |
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
tkalkirill
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-16665