IGNITE-16657 [Native Persistence 3.0] Implement partitions chunks merger#972
Merged
SammyVimes merged 14 commits intoapache:mainfrom Aug 4, 2022
Merged
IGNITE-16657 [Native Persistence 3.0] Implement partitions chunks merger#972SammyVimes merged 14 commits intoapache:mainfrom
SammyVimes merged 14 commits intoapache:mainfrom
Conversation
SammyVimes
reviewed
Aug 3, 2022
...ry/src/main/java/org/apache/ignite/internal/pagememory/persistence/compaction/Compactor.java
Show resolved
Hide resolved
SammyVimes
requested changes
Aug 3, 2022
| threadPoolExecutor.execute(merger); | ||
| } catch (RejectedExecutionException ignore) { | ||
| // Run the task synchronously. | ||
| merger.run(); |
Contributor
There was a problem hiding this comment.
Why should it throw this exception?
Contributor
Author
There was a problem hiding this comment.
This is a copy of the code from 2.0, the rejection can be if it was not possible to add a worker due to a stop or in the process of shutting down.
In theory, we won’t have this, because at the stop of the Compactor we say that we are canceling, we wait for all threads to complete and only then shutdown the thread pool.
I will remove this code here and at the Checkpointer.
...ry/src/main/java/org/apache/ignite/internal/pagememory/persistence/compaction/Compactor.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/ignite/internal/pagememory/persistence/store/DeltaFilePageStoreIo.java
Outdated
Show resolved
Hide resolved
isapego
pushed a commit
to isapego/ignite-3
that referenced
this pull request
Dec 26, 2024
…ast range-based scan apache#972
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-16657