IGNITE-17085 Support persistent case for page-memory-based MV storage #976
Conversation
| * Abstract implementation of {@link PartitionStorage} based on a {@link BplusTree}. | ||
| */ | ||
| // TODO: IGNITE-16644 Support snapshots. | ||
| abstract class AbstractPageMemoryPartitionStorage implements PartitionStorage { |
There was a problem hiding this comment.
I don't get this class. PartitionStorage is deprecated, what's the point? Can you please explain?
There was a problem hiding this comment.
We will get rid of this in a separate IGNITE-17466, but for now, let it be right
| @Override | ||
| public PageMemoryMvPartitionStorage createMvPartitionStorage(int partitionId) { | ||
| throw new UnsupportedOperationException("Not supported yet"); | ||
| public PersistentPageMemoryMvPartitionStorage createMvPartitionStorage(int partitionId) { |
There was a problem hiding this comment.
Do we need an old method for creating partition? It can just throw UnsupportedOperationException.
Why did you rename partId to partitionId in method that has nothing to do with your code btw? Why was it necessary?
There was a problem hiding this comment.
Let's get rid of the old method in ticket IGNITE-17466, what's stopping you from renaming?
...ain/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryTableStorage.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/ignite/internal/storage/pagememory/VolatilePageMemoryDataRegion.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/ignite/internal/storage/pagememory/VolatilePageMemoryDataRegion.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/ignite/internal/storage/pagememory/VolatilePageMemoryDataRegion.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/ignite/internal/storage/pagememory/mv/PageMemoryMvStorageIoModule.java
Outdated
Show resolved
Hide resolved
...emory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/RowVersionFreeList.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Test | ||
| void testVersionChainTreeRootPageId() { |
There was a problem hiding this comment.
What are these tests for? Just to test setters and getters?
There was a problem hiding this comment.
Yes, but also to check metadata snapshots for those setters
...emory/src/test/java/org/apache/ignite/internal/pagememory/persistence/PartitionMetaTest.java
Show resolved
Hide resolved
|
|
||
| CheckpointManager checkpointManager = dataRegion.checkpointManager(); | ||
|
|
||
| CheckpointTimeoutLock checkpointTimeoutLock = checkpointManager.checkpointTimeoutLock(); |
There was a problem hiding this comment.
Not related to this PR, but I think that CheckpointTimeoutLock is a very misleading name
There was a problem hiding this comment.
Can you create a ticket for fixing this?
There was a problem hiding this comment.
I don't know because we're trying to take the lock by timeout.
...ain/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryTableStorage.java
Outdated
Show resolved
Hide resolved
...g/apache/ignite/internal/storage/pagememory/mv/AbstractPageMemoryMvPartitionStorageTest.java
Outdated
Show resolved
Hide resolved
...g/apache/ignite/internal/storage/pagememory/mv/AbstractPageMemoryMvPartitionStorageTest.java
Outdated
Show resolved
Hide resolved
...g/apache/ignite/internal/storage/pagememory/mv/AbstractPageMemoryMvPartitionStorageTest.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/ignite/internal/storage/pagememory/VolatilePageMemoryDataRegion.java
Outdated
Show resolved
Hide resolved
...emory/src/test/java/org/apache/ignite/internal/pagememory/persistence/PartitionMetaTest.java
Outdated
Show resolved
Hide resolved
3 participants
https://issues.apache.org/jira/browse/IGNITE-17085