IGNITE-16664 IgniteToIgniteCdcStreamer named parameters added #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrov-mg
reviewed
Mar 5, 2022
modules/cdc-ext/src/test/java/org/apache/ignite/cdc/CdcIgniteToIgniteReplicationTest.java
Show resolved
Hide resolved
petrov-mg
reviewed
Mar 5, 2022
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/IgniteToIgniteCdcStreamer.java
Outdated
Show resolved
Hide resolved
petrov-mg
reviewed
Mar 5, 2022
| /** | ||
| * Sets whether entries only from primary nodes should be handled. | ||
| * | ||
| * @param onlyPrimary Kafka whether entries only from primary nodes should be handled. |
Contributor
There was a problem hiding this comment.
The word "Kafka" is redundant.
petrov-mg
reviewed
Mar 5, 2022
| } | ||
|
|
||
| /** | ||
| * Sets Ignite client node configuration thats will connect to destination cluster. |
petrov-mg
approved these changes
Mar 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.