IGNITE-22381 Fix java8 and java11 compilation#271
Closed
alex-plekhanov wants to merge 1 commit intoapache:masterfrom
Closed
IGNITE-22381 Fix java8 and java11 compilation#271alex-plekhanov wants to merge 1 commit intoapache:masterfrom
alex-plekhanov wants to merge 1 commit intoapache:masterfrom
Conversation
skorotkov
reviewed
May 31, 2024
| <module>../ignite</module> | ||
| </modules> | ||
| </profile> | ||
| <profile> |
Contributor
There was a problem hiding this comment.
I would suggest to not move the gatling-ext as a whole but the examples sub-module only.
It's the examples sub-module who use the gatling-maven-plugin which is built with jdk-11.
In other words modify the modules/gatling-ext/pom.xml moving the examples to java-11+ profile as
<modules>
<module>gatling-plugin</module>
</modules>
<profiles>
<profile>
<id>java-11+</id>
<activation>
<jdk>[11,)</jdk>
</activation>
<modules>
<module>examples</module>
</modules>
</profile>
</profiles>
Contributor
Author
There was a problem hiding this comment.
Unfortunately, gatling-plugin still requires java11 to run tests, it can be compiled on java8, but can't be used and will be failed on TC.
skorotkov
approved these changes
Jun 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gatling-extmodule underjava-11+profile (some dependencies of this module compiled with java-11 and can't be recognized by java-8).java-11+profile target compiler version is set to 11 (the same we have for the parentigniteproject, even if we try to compile with 1.8 target, compiled classes still can't be used by java-8, buttarget=1.8orrelease=1.8brokes usage ofadd-opens).-DskipTestor-Dmaven.test.skip=trueparameters are passed to maven (currently, this plugin always executed on test phase, even if we disable tests explicitely).--add-opensalso added tojava-11+(They are not mandatory by java-11, but they remove warnings about reflection usage).