IGNITE-17046 Move H2RowComparator logic to the core module #10080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-plekhanov
force-pushed
the
ignite-17046
branch
from
eeb334c to
1731b65
Compare
…t supported by core
alex-plekhanov
force-pushed
the
ignite-17046
branch
from
8f2de41 to
29f7372
Compare
timoninmaxim
requested changes
Jul 4, 2022
...es/core/src/main/java/org/apache/ignite/internal/cache/query/index/sorted/keys/IndexKey.java
Outdated
Show resolved
Hide resolved
.../apache/ignite/internal/cache/query/index/sorted/inline/types/BooleanInlineIndexKeyType.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/ignite/internal/cache/query/index/sorted/IndexRowCompartorImpl.java
Show resolved
Hide resolved
...s/core/src/main/java/org/apache/ignite/internal/processors/query/GridQueryRowDescriptor.java
Outdated
Show resolved
Hide resolved
...ing/src/main/java/org/apache/ignite/internal/processors/query/h2/database/H2PkHashIndex.java
Show resolved
Hide resolved
...g/src/main/java/org/apache/ignite/internal/processors/query/h2/database/H2ValueIndexKey.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/internal/cache/query/index/IndexProcessor.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/ignite/internal/cache/query/index/sorted/QueryIndexRowHandler.java
Outdated
Show resolved
Hide resolved
timoninmaxim
requested changes
Jul 7, 2022
.../src/main/java/org/apache/ignite/internal/cache/query/index/sorted/QueryIndexDefinition.java
Show resolved
Hide resolved
...src/main/java/org/apache/ignite/internal/cache/query/index/sorted/keys/DateTimeIndexKey.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/ignite/internal/cache/query/index/sorted/QueryIndexRowHandler.java
Show resolved
Hide resolved
.../src/main/java/org/apache/ignite/internal/cache/query/index/sorted/QueryIndexRowHandler.java
Outdated
Show resolved
Hide resolved
modules/indexing/src/test/java/org/apache/ignite/cache/query/IndexQueryAllTypesTest.java
Show resolved
Hide resolved
...main/java/org/apache/ignite/internal/cache/query/index/sorted/inline/InlineIndexKeyType.java
Outdated
Show resolved
Hide resolved
timoninmaxim
requested changes
Jul 7, 2022
.../src/main/java/org/apache/ignite/internal/cache/query/index/sorted/QueryIndexRowHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/ignite/internal/cache/query/index/sorted/QueryIndexRowHandler.java
Show resolved
Hide resolved
timoninmaxim
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes description:
IndexKeyTyperefactored to enum.GridH2RowDescriptorcleaned of H2 dependencies, renamed toGridQueryRowDescriptorand moved to the core module.QueryIndexDefinitioncleaned of H2 dependencies and moved to the core module.QueryIndexRowHandlercleaned of H2 dependencies and moved to the core module.H2RowComparatorremoved, basic types comparison logic (compare between numeric types, compare between date types) moved to theIndexRowCompartorImplclass (this logic can be used by Index Query). To compare other types between each other (for example, strings with dates, etc) the new index key class created (H2ValueIndexKeyclass). This class use H2 to compare different types. H2Valuewrapped into this class during execution of index scan by H2.