Skip to content

Conversation

@timoninmaxim
Copy link
Member

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

@timoninmaxim timoninmaxim force-pushed the IGNITE-17177_inc_snapshots branch from 06ee012 to 527bcd5 Compare March 8, 2023 08:26
@timoninmaxim timoninmaxim deleted the branch apache:IGNITE-17177_inc_snapshots March 9, 2023 19:52
Copy link
Contributor

@vitavin vitavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timoninmaxim Hi Maxim, Please check my 6 comments! Thank you!

Copy link

@annagobova annagobova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments after review

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to add "the" article:

After the link:...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "link" is invisible to a reader. This sentence actually looks like:

After data has rebalanced in the cluster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants