IGNITE-16181 SQL Calcite: Implement integer overflow#10802
Open
ivandasch wants to merge 3 commits intoapache:masterfrom
Open
IGNITE-16181 SQL Calcite: Implement integer overflow#10802ivandasch wants to merge 3 commits intoapache:masterfrom
ivandasch wants to merge 3 commits intoapache:masterfrom
Conversation
Fix cases when data overflow does not raise exception on arithmetic operations and data insert.
… and integer division
|
|
||
| /** */ | ||
| @Test | ||
| public void testArithmeticOverflow() { |
Contributor
There was a problem hiding this comment.
This test class should only check basic operator usage (one test for each operator) and should not be overloaded with other checks. Let's move this test to another class. For example, DataTypesTest.
|
|
||
| if (fromPrimitive != null) { | ||
| // E.g. from "float" to "double" | ||
| // check overflow for 'integer' subtypes |
Contributor
There was a problem hiding this comment.
I'm afraid this cover only non boxed privitives. In case of boxed primitives we will get something like longVal.intValue() without any checks.
|
SonarCloud Quality Gate failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.