IGNITE-20949 .NET: Thin client: Add service deployment awareness#11107
Merged
ptupitsyn merged 35 commits intoapache:masterfrom Dec 28, 2023
Merged
IGNITE-20949 .NET: Thin client: Add service deployment awareness#11107ptupitsyn merged 35 commits intoapache:masterfrom
ptupitsyn merged 35 commits intoapache:masterfrom
Conversation
ptupitsyn
changed the title
ptupitsyn
requested changes
Dec 19, 2023
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client/Services/ServicesClient.cs
Outdated
Show resolved
Hide resolved
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client/Services/ServicesClient.cs
Outdated
Show resolved
Hide resolved
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client/Services/ServicesClient.cs
Outdated
Show resolved
Hide resolved
ptupitsyn
reviewed
Dec 19, 2023
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client/Services/ServicesClient.cs
Outdated
Show resolved
Hide resolved
ptupitsyn
reviewed
Dec 19, 2023
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client/Services/ServicesClient.cs
Outdated
Show resolved
Hide resolved
ptupitsyn
changed the title
ptupitsyn
requested changes
Dec 20, 2023
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client/Services/ServicesClient.cs
Outdated
Show resolved
Hide resolved
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client/Services/ServicesClient.cs
Outdated
Show resolved
Hide resolved
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client/Services/ServicesClient.cs
Outdated
Show resolved
Hide resolved
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client/Services/ServicesClient.cs
Outdated
Show resolved
Hide resolved
modules/platforms/dotnet/Apache.Ignite.Core.Tests/Client/Services/ServiceAwarenessTest.cs
Outdated
Show resolved
Hide resolved
Contributor
|
I've pushed some changes to your branch - please review them. |
ptupitsyn
reviewed
Dec 21, 2023
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client/Services/ServicesClient.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
Wow. That for that bunch of fixes. Looks neat. I only reverted some code in |
ptupitsyn
reviewed
Dec 21, 2023
modules/platforms/dotnet/Apache.Ignite.Core.Tests/Client/Services/ServiceAwarenessTests.cs
Outdated
Show resolved
Hide resolved
ptupitsyn
approved these changes
Dec 21, 2023
Contributor
|
@Vladsz83 The PR looks good to me, thank you! Please get a green TC visa and we can merge it. |
Contributor
Author
Ok, good. Thanks. I'm gonna push one more commit. A test timeout issue arised on the Java test wit new topology poll period. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To improve service invocation performance, send client requests directly to the nodes where the service is deployed.