IGNITE-23344 Fixed log message in IgniteSnapshotManager::createSnapshot#11588
IGNITE-23344 Fixed log message in IgniteSnapshotManager::createSnapshot#11588timoninmaxim merged 5 commits intoapache:masterfrom vladnovoren:ignite-23344
Conversation
| compress, | ||
| encrypt | ||
| )); | ||
| var snpOpReq = new SnapshotOperationRequest( |
There was a problem hiding this comment.
Do not use var until you have great reason for that. Style guide for using var is here [1]. In current situation is better to use explicit type SnapshotOperationRequest. It's name is simple and the variable is used twice.
[1] https://openjdk.org/projects/amber/guides/lvti-style-guide
.../org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteSnapshotManager.java
Show resolved
Hide resolved
| * */ | ||
| @Test | ||
| public void testSnapshotCreationLog() throws Exception { | ||
| if (listenLog == null) |
There was a problem hiding this comment.
You don't need this check. listenLog must be new for every test to avoid side effects.
| if (listenLog == null) | ||
| listenLog = new ListeningTestLogger(log); | ||
|
|
||
| final int ENTRIES_CNT = 4; |
There was a problem hiding this comment.
ENTRIES_CNT -> entriesCnt. Use upper case for class-level constants only [1]
[1] https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-Naming
| LogListener matchLsnr2 = LogListener.matches("incremental=false, incIdx=-1").build(); | ||
| listenLog.registerListener(matchLsnr2); | ||
|
|
||
| LogListener noMatchLsnr = LogListener.matches("incremental=true, incIdx=-1").build(); |
There was a problem hiding this comment.
Let's add similar check for incremental snapshot in this test.
|
2 participants
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.