IGNITE-23681 Disallow IgniteCache#removeAll() within transaction #11713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoninmaxim
reviewed
Dec 9, 2024
modules/clients/src/test/java/org/apache/ignite/common/CacheEventSecurityContextTest.java
Outdated
Show resolved
Hide resolved
timoninmaxim
reviewed
Dec 9, 2024
modules/clients/src/test/java/org/apache/ignite/common/CacheEventSecurityContextTest.java
Show resolved
Hide resolved
timoninmaxim
reviewed
Dec 9, 2024
...ava/org/apache/ignite/internal/client/thin/ThinClientNonTransactionalOperationsInTxTest.java
Outdated
Show resolved
Hide resolved
J-Bakuli
force-pushed
the
ignite-23681
branch
2 times, most recently
from
3db8a27 to
72c03c7
Compare
J-Bakuli
force-pushed
the
ignite-23681
branch
from
72c03c7 to
f9365f8
Compare
modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpClientCache.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/ignite/internal/client/thin/ThinClientNonTransactionalOperationsInTxTest.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpClientCache.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpClientCache.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/ignite/internal/processors/cache/distributed/GridDistributedCacheAdapter.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpClientCache.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/ignite/internal/client/thin/ThinClientNonTransactionalOperationsInTxTest.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/ignite/internal/client/thin/ThinClientNonTransactionalOperationsInTxTest.java
Outdated
Show resolved
Hide resolved
...apache/ignite/internal/processors/cache/transactions/NonTransactionalOperationsInTxTest.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/ignite/internal/processors/cache/distributed/GridDistributedCacheAdapter.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/ignite/internal/processors/cache/distributed/GridDistributedCacheAdapter.java
Outdated
Show resolved
Hide resolved
timoninmaxim
approved these changes
Dec 24, 2024
luchnikovbsk
pushed a commit
to luchnikovbsk/ignite
that referenced
this pull request
Jan 31, 2025
okreda1
pushed a commit
to okreda1/ignite
that referenced
this pull request
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IgniteCache#removeAll invocation are not transactional.
But, currently, Ignite allow to invoke clear inside transaction.
This lead to unexpected behavior and hides business logic errors.
We must disallow IgniteCache#removeAll call inside transaction.
TCbot2
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.