IGNITE-28243 Keep service descriptor even if no deployments#12910
Merged
nizhikov merged 10 commits intoapache:masterfrom Mar 19, 2026
Merged
IGNITE-28243 Keep service descriptor even if no deployments#12910nizhikov merged 10 commits intoapache:masterfrom
nizhikov merged 10 commits intoapache:masterfrom
Conversation
shishkovilja
approved these changes
Mar 19, 2026
.../java/org/apache/ignite/internal/processors/service/IgniteServiceDeployOnJoinedNodeTest.java
Outdated
Show resolved
Hide resolved
| * Tests check the following case: | ||
| * 1. Node "A" starts with the service configuration. But, NodeFilter filter out node "A". | ||
| * 2. Node "B" starts and NodeFilter conforms it. | ||
| * 3. Expect that service will be deployed on node "B". |
Contributor
There was a problem hiding this comment.
Suggested change
| * 3. Expect that service will be deployed on node "B". | |
| * 3. It is expected that service will be deployed on node "B". |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some users implements the following scenario:
n -> n.isClient().This case was broken in the 66a4a2d
This PR fix regression.