Skip to content

IGNITE-28610 Implement savepoint for Key-Value API for pessimistic transactions #13080

Merged
vldpyatkov merged 9 commits into
apache:masterfrom
vldpyatkov:ignite-28610
Apr 30, 2026
Merged

IGNITE-28610 Implement savepoint for Key-Value API for pessimistic transactions #13080
vldpyatkov merged 9 commits into
apache:masterfrom
vldpyatkov:ignite-28610

Conversation

@vldpyatkov
Copy link
Copy Markdown
Contributor

@tkalkirill tkalkirill changed the title IGNITE-28610 IGNITE-28610 Implement savepoint for Key-Value API for pessimistic transactions Apr 28, 2026
Copy link
Copy Markdown
Contributor

@tkalkirill tkalkirill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phase 1

Comment thread modules/core/src/main/java/org/apache/ignite/transactions/Transaction.java Outdated
Comment thread modules/core/src/main/java/org/apache/ignite/transactions/Transaction.java Outdated
Comment thread modules/core/src/main/java/org/apache/ignite/transactions/Transaction.java Outdated

/** Savepoint rollback flag. */
@Order(1)
public boolean forSavepoint;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check Rolling Upgrade check suggests there might be a problem. Let's figure out what might be wrong with the feature authors.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see an issue with this change from the point of view of rolling upgrades. As I understand it, Ignite can update only by restarting on the same storage; this PR does not touch persistence classes.
What do you think can be wrong?

@github-actions
Copy link
Copy Markdown

Possible compatibility issues. Please, check rolling upgrade cases

This PR modifies protected classes (with Order annotation).
Changes to these classes can break rolling upgrade compatibility.

Affected files:

  • modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridNearUnlockRequest.java
  • modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxEntry.java

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
7 New Code Smells (required ≤ 1)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@vldpyatkov vldpyatkov merged commit 37e92c5 into apache:master Apr 30, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants