IGNITE-10944: Plugin discovery data from PluginProvider.provideDiscoveryData should be available in PluginProvider.validateNewNode#5865
Closed
mcherkasov wants to merge 6 commits intoapache:masterfrom
Closed
Conversation
mcherkasov
force-pushed
the
IGNITE-10944
branch
from
4353607 to
b301f85
Compare
validateNode with ClusterNode only is deprecated.
mcherkasov
force-pushed
the
IGNITE-10944
branch
from
b301f85 to
8aef0e4
Compare
mcherkasov
changed the title
alamar
suggested changes
Jan 24, 2019
Contributor
There was a problem hiding this comment.
Comment is desired as per CC
Contributor
There was a problem hiding this comment.
Comment is desired as per CC
| @@ -0,0 +1,117 @@ | |||
| package org.apache.ignite.plugin; | |||
| import org.apache.ignite.configuration.IgniteConfiguration; | ||
| import org.jetbrains.annotations.Nullable; | ||
|
|
||
| public class NodeValidationPluginProvider implements PluginProvider, IgnitePlugin { |
Contributor
There was a problem hiding this comment.
Please add comments everywhere as per CC
Contributor
There was a problem hiding this comment.
Do you really need a suite for that? Is it present on TC?
Contributor
There was a problem hiding this comment.
Why not add test class directly?
| import org.junit.runners.JUnit4; | ||
|
|
||
| @RunWith(JUnit4.class) | ||
| public class PluginNodeValidationTest extends GridCommonAbstractTest { |
Contributor
There was a problem hiding this comment.
Please add comments as per CC
Contributor
There was a problem hiding this comment.
"public static" is a bad idea, please make it a setter at least.
…new method has default implementation.
mcherkasov
added a commit
to gridgain/apache-ignite
that referenced
this pull request
Jan 24, 2019
…deprecate old method - Fixes apache#5865. Signed-off-by: Ilya Kasnacheev <ilya.kasnacheev@gmail.com> (cherry picked from commit 4ea443c)
mcherkasov
added a commit
to gridgain/apache-ignite
that referenced
this pull request
Jan 24, 2019
…deprecate old method - Fixes apache#5865. Signed-off-by: Ilya Kasnacheev <ilya.kasnacheev@gmail.com> (cherry picked from commit 4ea443c)
mcherkasov
added a commit
to gridgain/apache-ignite
that referenced
this pull request
Jan 24, 2019
…deprecate old method - Fixes apache#5865. Signed-off-by: Ilya Kasnacheev <ilya.kasnacheev@gmail.com> (cherry picked from commit 4ea443c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.