IGNITE-11703: Implemented default implementation of boilerplate#6435
Closed
isapego wants to merge 3 commits into
Closed
IGNITE-11703: Implemented default implementation of boilerplate#6435isapego wants to merge 3 commits into
isapego wants to merge 3 commits into
Conversation
pavlukhin
reviewed
Apr 15, 2019
| }; | ||
|
|
||
| /** | ||
| * Default implementations of BinaryType hashing functions. |
Contributor
There was a problem hiding this comment.
Comment does not reflect non-nullable behavior.
| { | ||
| return one.val1 == two.val1 && one.val2 == two.val2 && | ||
| return one.val1 == two.val1 && one.val2 == two.val2 && | ||
| one.rawVal1 == two.rawVal1 &&one.rawVal2 == two.rawVal2; |
Contributor
There was a problem hiding this comment.
Please add a space after && in &&one.rawVal2 == two.rawVal2
Contributor
Author
There was a problem hiding this comment.
Wow, that's what I call attentiveness )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BinaryType methods.