IGNITE-12048 Bugs & tests fixes#6756
Closed
dgovorukhin wants to merge 7 commits intoapache:masterfrom
Closed
Conversation
stevenchen3
pushed a commit
to stevenchen3/ignite
that referenced
this pull request
Aug 9, 2019
Page replacement can reload invalid page during checkpoint
There is a race between writeCheckpointPages and page replacement process:
Checkpointer thread begins a checkpoint
Checkpointer thread calls getPageForCheckpoint(), which will copy page content and clear dirty flag
Page replacement tries to find a page for replacement and chooses this page, the page is thrown away
Before the page is written back to the store, the page is acquired again.
As a result, an older copy of the page is brought back to memory, which causes all kinds of corruption exceptions and assertions.
checkpointReadLock() may hang during node stop
I got this hang during one of PDS (Indexing) runs (thread-dump is attached).
The following code hang:
checkpointer.wakeupForCheckpoint(0, "too many dirty pages").cpBeginFut
.getUninterruptibly();
It looks like wakeupForCheckpoint can be called after the checkpointer is stopped and cpBeginFut will be never completed.
Fixed ZookeeperDiscoveryCommunicationFailureTest.testCommunicationFailureResolve_CachesInfo1
Fixed *.testFailAfterStart
Reduce test time execution (scale factor for a long-running tests)
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.