IGNITE-12181 Fixed assertion for non-persisted group in PDS enabled cluster.#6929
Merged
Mmuzaf merged 7 commits intoapache:masterfrom Oct 3, 2019
Merged
IGNITE-12181 Fixed assertion for non-persisted group in PDS enabled cluster.#6929Mmuzaf merged 7 commits intoapache:masterfrom
Mmuzaf merged 7 commits intoapache:masterfrom
Conversation
xtern
changed the title
xtern
force-pushed
the
IGNITE-12181
branch
4 times, most recently
from
33036f0 to
4d15af3
Compare
Mmuzaf
reviewed
Oct 2, 2019
Comment on lines
+67
to
+72
| /** {@inheritDoc} */ | ||
| @Test | ||
| @Ignore | ||
| @Override public void testTopologyChangesWithConstantLoadOnInMemoryCache() { | ||
| // No-op. | ||
| } |
Contributor
There was a problem hiding this comment.
I think it is not good for adding new ignored tests. Why we should do so?
Contributor
Author
There was a problem hiding this comment.
Because testTopologyChangesWithConstantLoad is the best that I found to check rebalancing with indexing, but as you may know, historical (WAL) rebalancing doesn't support for in-memory caches, so test case with in-memory cache should be ignored somehow.
Contributor
Author
There was a problem hiding this comment.
I've updated PR, added a new test for mixed configurations of the data regions.
Mmuzaf
reviewed
Oct 2, 2019
Comment on lines
+68
to
+72
| @Test | ||
| @Ignore | ||
| @Override public void testTopologyChangesWithConstantLoadOnInMemoryCache() { | ||
| // No-op. | ||
| } |
Mmuzaf
approved these changes
Oct 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.