IGNITE-12261 - Issue with adding nested index dynamically#6947
Closed
kotari4u wants to merge 1 commit intoapache:masterfrom
Closed
IGNITE-12261 - Issue with adding nested index dynamically#6947kotari4u wants to merge 1 commit intoapache:masterfrom
kotari4u wants to merge 1 commit intoapache:masterfrom
Conversation
http://apache-ignite-users.70518.x6.nabble.com/Issue-with-adding-nested-index-dynamically-tt29571.html As discussed in the user group ( please check the link ), I have added fix in this class, please let me know if it can be merged and new version can be released. Please let me know for any issue with this commit. Thank you
Author
|
Can you please check this pull request. Thanks |
skarpushin
reviewed
Oct 8, 2019
| fullName.append(prop); | ||
|
|
||
| String alias = aliases.get(fullName.toString()); | ||
| String alias = aliases.get(fullName.toString()) == null ? fullName.toString() : aliases.get(fullName.toString()); |
There was a problem hiding this comment.
Why do aliases.get(fullName.toString()); twice?
Suggestion:
String alias = aliases.get(fullName.toString());
if (alias == null) {
alias = fullName.toString();
}
Author
|
Creatdd another pull request with comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://apache-ignite-users.70518.x6.nabble.com/Issue-with-adding-nested-index-dynamically-tt29571.html
As discussed in the user group ( please check the link ), I have added fix in this class, please let me know if it can be merged and new version can be released. Please let me know for any issue with this commit. Thank you