IGNITE-1606 NPE during node stop due to nullified logger in TcpCommunicationSpi#7004
Open
x-kreator wants to merge 2 commits intoapache:masterfrom
Open
IGNITE-1606 NPE during node stop due to nullified logger in TcpCommunicationSpi#7004x-kreator wants to merge 2 commits intoapache:masterfrom
x-kreator wants to merge 2 commits intoapache:masterfrom
Conversation
nizhikov
reviewed
Oct 25, 2019
| /** | ||
| * Same as {@link #GENERIC} excluding {@link ResourceAnnotation#LOGGER}. | ||
| */ | ||
| GENERIC_CLEANABLE( |
Contributor
There was a problem hiding this comment.
Can we just exclude LOGGER from GENERIC set instead of the creation of a new set?
New set is error-prone.
Some contributor can forget to add new ReourceAnnotation to it.
This will lead to hard to find issues.
Contributor
Author
There was a problem hiding this comment.
Is it right that you suggest to add a new AnnotationSet.LOGGER with ResourceAnnotation.LOGGER only and use it at the points where AnnotationSet.GENERIC is injecting but don't use one at cleanup?
Contributor
There was a problem hiding this comment.
I think we can just use existing LOGGER annotation but don't clean up it.
Contributor
Author
There was a problem hiding this comment.
Thanks for review, code was updated according your recommendation.
x-kreator
force-pushed
the
ignite-1606
branch
from
161e2f8 to
1fe0252
Compare
…at LoggerResource javadoc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.