IGNITE-12628 Add tests for jmx metrics return types

modules/core/src/test/java/org/apache/ignite/internal/GridJobStealingSelfTest.java

@@ -51,6 +51,7 @@
 import org.apache.ignite.testframework.junits.common.GridCommonTest;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
+import org.junit.Ignore;
 import org.junit.Test;
 
 /**
@@ -301,6 +302,19 @@ public void testProjectionPredicateDifferentClassLoaders() throws Exception {
             ret.get(ignite3.cluster().localNode().id());
     }
 
+    /**
+     * @throws Exception If fatiled.
+     */
+    @Ignore("https://issues.apache.org/jira/browse/IGNITE-12629")
+    @Test
+    public void testJobStealingMbeanValidity() throws Exception {
+        String[] beansToValidate = new String[] {
+            "org.apache.ignite.spi.collision.jobstealing.JobStealingCollisionSpi$JobStealingCollisionSpiMBeanImpl",
+            "org.apache.ignite.spi.failover.jobstealing.JobStealingFailoverSpi$JobStealingFailoverSpiMBeanImpl"};
+
+        validateMbeans(ignite1, beansToValidate);
+    }
+
     /** {@inheritDoc} */
     @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
         IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);

modules/core/src/test/java/org/apache/ignite/internal/GridMBeansTest.java

@@ -17,12 +17,12 @@
 
 package org.apache.ignite.internal;
 
+import javax.management.ObjectName;
 import org.apache.ignite.configuration.ExecutorConfiguration;
 import org.apache.ignite.configuration.IgniteConfiguration;
 import org.apache.ignite.internal.util.IgniteUtils;
+import org.apache.ignite.internal.util.typedef.G;
 import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
-
-import javax.management.ObjectName;
 import org.junit.Test;
 
 /**
@@ -86,4 +86,34 @@ private void checkBean(String grp, String name, String attributeName, Object exp
 
         assertEquals(expAttributeVal, attributeVal);
     }
+
+    /**
+     * @throws Exception If failed to validate methods.
+     */
+    @Test
+    public void testBeansClasses() throws Exception {
+        String[] clsNames = new String[]{"org.apache.ignite.internal.ClusterLocalNodeMetricsMXBeanImpl",
+            "org.apache.ignite.internal.ClusterMetricsMXBeanImpl",
+            "org.apache.ignite.internal.IgniteKernal",
+            "org.apache.ignite.internal.IgnitionMXBeanAdapter",
+            "org.apache.ignite.internal.StripedExecutorMXBeanAdapter",
+            "org.apache.ignite.internal.ThreadPoolMXBeanAdapter",
+            "org.apache.ignite.internal.TransactionMetricsMxBeanImpl",
+            "org.apache.ignite.internal.TransactionsMXBeanImpl",
+            "org.apache.ignite.internal.processors.cache.persistence.DataRegionMetricsMXBeanImpl",
+            "org.apache.ignite.internal.processors.cache.persistence.DataStorageMXBeanImpl",
+            "org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagelocktracker.PageLockTrackerMXBeanImpl",
+            "org.apache.ignite.internal.processors.cluster.BaselineAutoAdjustMXBeanImpl",
+            "org.apache.ignite.internal.processors.odbc.ClientListenerProcessor$ClientProcessorMXBeanImpl",
+            "org.apache.ignite.internal.worker.FailureHandlingMxBeanImpl",
+            "org.apache.ignite.spi.checkpoint.sharedfs.SharedFsCheckpointSpi$SharedFsCheckpointSpiMBeanImpl",
+            "org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi$TcpCommunicationSpiMBeanImpl",
+            "org.apache.ignite.spi.deployment.local.LocalDeploymentSpi$LocalDeploymentSpiMBeanImpl",
+            "org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi$TcpDiscoverySpiMBeanImpl",
+            "org.apache.ignite.spi.eventstorage.memory.MemoryEventStorageSpi$MemoryEventStorageSpiMBeanImpl",
+            "org.apache.ignite.spi.failover.always.AlwaysFailoverSpi$AlwaysFailoverSpiMBeanImpl",
+            "org.apache.ignite.spi.loadbalancing.roundrobin.RoundRobinLoadBalancingSpi$RoundRobinLoadBalancingSpiMBeanImpl"};
+
+        validateMbeans(G.allGrids().get(0), clsNames);
+    }
 }

modules/core/src/test/java/org/apache/ignite/internal/GridMbeansMiscTest.java

@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal;
+
+import org.apache.ignite.Ignite;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.spi.checkpoint.CheckpointSpi;
+import org.apache.ignite.spi.checkpoint.sharedfs.SharedFsCheckpointSpi;
+import org.apache.ignite.spi.collision.CollisionSpi;
+import org.apache.ignite.spi.collision.fifoqueue.FifoQueueCollisionSpi;
+import org.apache.ignite.spi.collision.priorityqueue.PriorityQueueCollisionSpi;
+import org.apache.ignite.spi.deployment.DeploymentSpi;
+import org.apache.ignite.spi.deployment.local.LocalDeploymentSpi;
+import org.apache.ignite.spi.loadbalancing.LoadBalancingSpi;
+import org.apache.ignite.spi.loadbalancing.adaptive.AdaptiveLoadBalancingSpi;
+import org.apache.ignite.spi.loadbalancing.weightedrandom.WeightedRandomLoadBalancingSpi;
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.junit.Test;
+
+/**
+ * Checks mbeans validity for miscelenious spis.
+ */
+public class GridMbeansMiscTest extends GridCommonAbstractTest {
+    /** */
+    private CollisionSpi collisionSpi;
+
+    /** */
+    private LoadBalancingSpi loadBalancingSpi;
+
+    /** */
+    private DeploymentSpi deploymentSpi;
+
+    /** */
+    private CheckpointSpi checkpointSpi;
+
+    /** {@inheritDoc} */
+    @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
+        IgniteConfiguration cfg =  super.getConfiguration(igniteInstanceName);
+
+        if (collisionSpi != null)
+            cfg.setCollisionSpi(collisionSpi);
+
+        if (loadBalancingSpi != null)
+            cfg.setLoadBalancingSpi(loadBalancingSpi);
+
+        if (deploymentSpi != null)
+            cfg.setDeploymentSpi(deploymentSpi);
+
+        if (checkpointSpi != null)
+            cfg.setCheckpointSpi(checkpointSpi);
+
+        return cfg;
+    }
+
+    /**
+     * @throws Exception If failed.
+     */
+    @Test
+    public void testMbeansSet1() throws Exception {
+        collisionSpi = new FifoQueueCollisionSpi();
+        loadBalancingSpi = new WeightedRandomLoadBalancingSpi();
+        deploymentSpi = new LocalDeploymentSpi();
+        checkpointSpi = new SharedFsCheckpointSpi();
+
+        String[] beansToValidate = new String[] {
+            "org.apache.ignite.spi.collision.fifoqueue.FifoQueueCollisionSpi$FifoQueueCollisionSpiMBeanImpl",
+            "org.apache.ignite.spi.loadbalancing.weightedrandom.WeightedRandomLoadBalancingSpi$WeightedRandomLoadBalancingSpiMBeanImpl",
+            "org.apache.ignite.spi.deployment.local.LocalDeploymentSpi$LocalDeploymentSpiMBeanImpl",
+            "org.apache.ignite.spi.checkpoint.sharedfs.SharedFsCheckpointSpi$SharedFsCheckpointSpiMBeanImpl"
+        };
+
+        doTest(beansToValidate);
+    }
+
+    /**
+     * @throws Exception If failed.
+     */
+    @Test
+    public void testMbeansSet2() throws Exception {
+        collisionSpi = new PriorityQueueCollisionSpi();
+        loadBalancingSpi = new AdaptiveLoadBalancingSpi();
+
+        String[] beansToValidate = new String[] {
+            "org.apache.ignite.spi.collision.priorityqueue.PriorityQueueCollisionSpi$PriorityQueueCollisionSpiMBeanImpl",
+            "org.apache.ignite.spi.loadbalancing.adaptive.AdaptiveLoadBalancingSpi$AdaptiveLoadBalancingSpiMBeanImpl"
+        };
+
+        doTest(beansToValidate);
+    }
+
+    /** */
+    private void doTest(String[] beansToValidate) throws Exception {
+        try {
+            Ignite ignite = startGrid();
+
+            validateMbeans(ignite, beansToValidate);
+        }
+        finally {
+            stopAllGrids();
+        }
+    }
+}

modules/core/src/test/java/org/apache/ignite/internal/managers/checkpoint/GridCheckpointTaskSelfTest.java

@@ -118,6 +118,14 @@ public void testReduce() throws Exception {
         grid(1).compute().execute(ReduceTestTask.class, null);
     }
 
+    /**
+     * @throws Exception If failed.
+     */
+    @Test
+    public void testCacheCheckpointSpiMbeanValidity() throws Exception {
+        validateMbeans(grid(1), "org.apache.ignite.spi.checkpoint.cache.CacheCheckpointSpi$CacheCheckpointSpiMBeanImpl");
+    }
+
     /**
      * Failover test task.
      */

modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/EvictionAbstractTest.java

@@ -735,6 +735,24 @@ public void testPartitionedNearEnabledMultiThreaded() throws Exception {
         checkPartitionedMultiThreaded();
     }
 
+    /**
+     * @throws Exception if failed.
+     */
+    @Test
+    public void testEvictionPolicyMbeanValidity() throws Exception {
+        try {
+            Ignite ignite = startGrids(2);
+
+            //Instantiate policy object to know exact class.
+            EvictionPolicy plc = createPolicy(0);
+
+            validateMbeans(ignite, plc.getClass().getName());
+        }
+        finally {
+            stopAllGrids();
+        }
+    }
+
     /**
      * @throws Exception If failed.
      */