Skip to content

Conversation

@ingvard
Copy link
Contributor

@ingvard ingvard commented Jul 29, 2020

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

* @throws Exception If failed.
* Don't use this method in test, it doesn't call.
*/
@Deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this annotation is too restrictive. Let's add a message to the Javadoc.
For instance: Be aware that this method is not called by startGrid(int idx)

@asfgit asfgit closed this in e7b874d Aug 5, 2020
kartiksomani pushed a commit to kartiksomani/ignite that referenced this pull request Sep 15, 2020
…occur due to java thin client connecting. Fixes apache#8096

Signed-off-by: Slava Koptilin <slava.koptilin@gmail.com>
ymolochkov pushed a commit to ymolochkov/ignite that referenced this pull request Nov 19, 2020
…occur due to java thin client connecting. Fixes apache#8096

Signed-off-by: Slava Koptilin <slava.koptilin@gmail.com>

(cherry picked from commit e7b874d)
ymolochkov pushed a commit to ymolochkov/ignite that referenced this pull request Nov 20, 2020
…occur due to java thin client connecting. Fixes apache#8096

Signed-off-by: Slava Koptilin <slava.koptilin@gmail.com>

(cherry picked from commit e7b874d)
ymolochkov pushed a commit to ymolochkov/ignite that referenced this pull request Nov 27, 2020
…occur due to java thin client connecting. Fixes apache#8096

Signed-off-by: Slava Koptilin <slava.koptilin@gmail.com>

(cherry picked from commit e7b874d)
ymolochkov pushed a commit to ymolochkov/ignite that referenced this pull request Nov 27, 2020
…occur due to java thin client connecting. Fixes apache#8096

Signed-off-by: Slava Koptilin <slava.koptilin@gmail.com>

(cherry picked from commit e7b874d)
Mmuzaf pushed a commit that referenced this pull request Dec 2, 2020
…occur due to java thin client connecting. Fixes #8096

Signed-off-by: Slava Koptilin <slava.koptilin@gmail.com>

(cherry picked from commit e7b874d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants