-
Notifications
You must be signed in to change notification settings - Fork 1.9k
IGNITE-13458 RebalancingPartitionsTotal metrics #8254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkalkirill
reviewed
Sep 18, 2020
| private final AtomicLong partitionsLeft = new AtomicLong(0); | ||
|
|
||
| /** The total number of cache group partitions to be rebalanced. */ | ||
| private final AtomicLong partitionsTotal = new AtomicLong(0); |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove.
| "The number of cache group partitions left to be rebalanced."); | ||
|
|
||
| mreg.register("RebalancingPartitionsTotal", | ||
| () -> rebalanceFut.rebalancingParts.values().stream().mapToInt(Set::size).sum(), |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This value is a constant and should be precomputed on future creation to make metrics overhead as low as possible.
ingvard
added a commit
to gridgain/apache-ignite
that referenced
this pull request
Oct 14, 2020
ymolochkov
pushed a commit
to ymolochkov/ignite
that referenced
this pull request
Nov 18, 2020
ymolochkov
pushed a commit
to ymolochkov/ignite
that referenced
this pull request
Nov 19, 2020
ymolochkov
pushed a commit
to ymolochkov/ignite
that referenced
this pull request
Nov 27, 2020
Mmuzaf
pushed a commit
that referenced
this pull request
Dec 2, 2020
Signed-off-by: Alexey Scherbakov <alexey.scherbakoff@gmail.com> (cherry picked from commit eabe50d)
vladErmakov07
pushed a commit
to gridgain/apache-ignite
that referenced
this pull request
Jun 15, 2021
apache#8254. (cherry picked from commit cbba7ec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.