Skip to content

Conversation

@ingvard
Copy link
Contributor

@ingvard ingvard commented Sep 17, 2020

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

private final AtomicLong partitionsLeft = new AtomicLong(0);

/** The total number of cache group partitions to be rebalanced. */
private final AtomicLong partitionsTotal = new AtomicLong(0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove.

"The number of cache group partitions left to be rebalanced.");

mreg.register("RebalancingPartitionsTotal",
() -> rebalanceFut.rebalancingParts.values().stream().mapToInt(Set::size).sum(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value is a constant and should be precomputed on future creation to make metrics overhead as low as possible.

@asfgit asfgit closed this in eabe50d Sep 24, 2020
ingvard added a commit to gridgain/apache-ignite that referenced this pull request Oct 14, 2020
ymolochkov pushed a commit to ymolochkov/ignite that referenced this pull request Nov 18, 2020
…8254.

Signed-off-by: Alexey Scherbakov <alexey.scherbakoff@gmail.com>

(cherry picked from commit eabe50d)
ymolochkov pushed a commit to ymolochkov/ignite that referenced this pull request Nov 19, 2020
…8254.

Signed-off-by: Alexey Scherbakov <alexey.scherbakoff@gmail.com>

(cherry picked from commit eabe50d)
ymolochkov pushed a commit to ymolochkov/ignite that referenced this pull request Nov 27, 2020
…8254.

Signed-off-by: Alexey Scherbakov <alexey.scherbakoff@gmail.com>

(cherry picked from commit eabe50d)
Mmuzaf pushed a commit that referenced this pull request Dec 2, 2020
Signed-off-by: Alexey Scherbakov <alexey.scherbakoff@gmail.com>

(cherry picked from commit eabe50d)
vladErmakov07 pushed a commit to gridgain/apache-ignite that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants