IGNITE-13551 .NET: Enable ClientServerCompatibilityTest on Linux #8331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isapego
approved these changes
Oct 9, 2020
Comment on lines
+49
to
+50
| if (process != null) | ||
| throw new Exception("PlatformProcessUtils can't start more than one process at a time."); |
Contributor
There was a problem hiding this comment.
Is this a limitation, or do we just not need several processes right now and this was the simpliest implementation?
Contributor
Author
There was a problem hiding this comment.
It would be great to return PID and then use it to kill the process. Unfortunately, Process.pid() was only added in Java 9, and we have to be able to run on Java 8.
So yes, this is a simplification - good enough for tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Java code to start and stop processes to avoid SIGCHLD conflicts.
Java and .NET both install SIGCHLD handler to deal with child processes. Since Ignite direct-io already uses Java process API, we can't use .NET process API in tests.