Skip to content

Conversation

@isapego
Copy link
Contributor

@isapego isapego commented Oct 13, 2020

Added flags for all supported compilers to treat warnings as errors and fixed all found errors.

The "failure-on-warning" mode is introduced for CMake. It is disabled by default to improve user experience, but can be enabled with -DWARNINGS_AS_ERRORS=ON CMake flag and is encouraged for the use by developers as it is now used for all CMake TeamCity runs.

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

@isapego isapego changed the title IGNITE-11653: CPP Fixed compiler warnings IGNITE-11653: CPP Fix compiler warnings and treat warnings as errors Oct 13, 2020
@isapego isapego changed the title IGNITE-11653: CPP Fix compiler warnings and treat warnings as errors IGNITE-11653: CPP Fix compiler warnings, treat warnings as errors Oct 13, 2020
@asfgit asfgit closed this in 6242188 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants