Calcite new version (1.26.0) #8380
Conversation
...alcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/Inbox.java
Show resolved
Hide resolved
| List<RexNode> operands = RelOptUtil.disjunctions(dnf); | ||
|
|
||
| if (operands.size() != 2) | ||
| if (operands.size() != 2 || RexUtil.find(SqlKind.IS_NULL).anyContain(operands)) |
There was a problem hiding this comment.
i suppose we don`t have any test for it ?
There was a problem hiding this comment.
this fix isn't the best one, but we need a way to detect somehow a filter what is a result of previous rule call, otherwise we'll have infinity rule match queue. And I have no idea how we would write a specific test for it (a planer plans a query in finite number of steps, it means a condition works)
|
|
||
| /** */ | ||
| @SuppressWarnings("ClassNameSameAsAncestorName") | ||
| public interface Config extends RelRule.Config { |
There was a problem hiding this comment.
Our static analysis engine detects that your pull request includes a change that class name shadows simple name of interface. According to best practice, it can be exceptionally confusing, creating many situations where you have to look at import statements to resolve references, and creating many opportunities to accidentally define methods that don't override the methods in their superclasses.
|
|
||
| /** */ | ||
| @SuppressWarnings("ClassNameSameAsAncestorName") | ||
| public interface Config extends RelRule.Config { |
There was a problem hiding this comment.
Our static analysis engine detects that your pull request includes a change that class name shadows simple name of interface. According to best practice, it can be exceptionally confusing, creating many situations where you have to look at import statements to resolve references, and creating many opportunities to accidentally define methods that don't override the methods in their superclasses.
3 participants
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.