IGNITE-13895: SSL usage in ducktape tests #8623
Conversation
| rm ${ALIAS}.jks | ||
| rm ${ALIAS}.pem | ||
|
|
||
| keytool -genkeypair -keystore ${ALIAS}.jks -alias ${ALIAS} -dname "${DNAME}" -ext bc:c -storepass ${PSWD} \ |
There was a problem hiding this comment.
Please check bash checkstyle with Inteliij IDEA plugin. It will write down all possible issues. At least ${PSWD} must be in quotes, as it can contain special symbols like &.
| DUCKTAPE_OPTIONS="$DUCKTAPE_OPTIONS --max-parallel $MAX_PARALLEL" | ||
| fi | ||
|
|
||
| "$SCRIPT_DIR"/../certs/mkcerts.sh |
There was a problem hiding this comment.
This is mechanism for docker env. How is it going to be distributed on real nodes on Jenkins?
There was a problem hiding this comment.
first certificates are generated, then copied to the nodes
|
|
||
| def __init__(self, cluster, text_context): | ||
| def __init__(self, cluster, | ||
| key_store_jks: str = None, key_store_pwd: str = "123456", |
There was a problem hiding this comment.
Password 123456 is a magic variable. Are there any alternatives? Config, global variable, param, or smth else?
At least setting global variable in run_tests.sh looks better.
| Ssl test. | ||
| """ | ||
| @cluster(num_nodes=3) | ||
| @ignite_versions(str(DEV_BRANCH), str(LATEST_2_9), str(LATEST_2_8)) |
There was a problem hiding this comment.
Actually do we need check of LATEST versions?
There was a problem hiding this comment.
I think yes, these versions are now used
… DEFAULT_ADMIN_KEYSTORE
…ath for server, client, admin through global parameters
# Conflicts: # modules/ducktests/tests/ignitetest/services/utils/ignite_aware.py
| """ | ||
| This module contains the base class to build Ignite aware application written on java. | ||
| """ | ||
|
|
5 participants
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.