Skip to content

IGNITE-13954 TcpDiscoverySpi incomprehensible metric description #8656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
a-polyakov wants to merge 1 commit into from
Closed

IGNITE-13954 TcpDiscoverySpi incomprehensible metric description #8656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2216,10 +2216,12 @@ ClusterNode getNode0(UUID nodeId) {

/**
* Thread that cleans IP finder and keeps it in the correct state, unregistering
* addresses of the nodes that has left the topology.
* addresses of the nodes that has left the topology and re-registries missing addresses.
* <p>
* This thread should run only on coordinator node and will clean IP finder
* if and only if {@link org.apache.ignite.spi.discovery.tcp.ipfinder.TcpDiscoveryIpFinder#isShared()} is {@code true}.
* <p>
* Run with frequency {@link org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi#ipFinderCleanFreq}
*/
private class IpFinderCleaner extends IgniteSpiThread {
/**
Expand Down
20 changes: 16 additions & 4 deletions modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,11 @@ public class TcpDiscoverySpi extends IgniteSpiAdapter implements IgniteDiscovery
/** Network timeout. */
protected long netTimeout = DFLT_NETWORK_TIMEOUT;

/** Join timeout. */
/**
* Join timeout, in milliseconds. Time to wait for joining. If node cannot connect to any address from the IP
* finder, the node continues to try to join during this timeout. If all addresses still do not respond, an
* exception will occur and the node will fail to start. If 0 is specified, it means wait forever.
*/
protected long joinTimeout = DFLT_JOIN_TIMEOUT;

/** Thread priority for all threads started by SPI. */
Expand Down Expand Up @@ -400,7 +404,12 @@ public class TcpDiscoverySpi extends IgniteSpiAdapter implements IgniteDiscovery
/** Default SO_LINGER to use for socket. Set negative to disable, non-negative to enable, default is {@DFLT_SO_LINGER }. */
private int soLinger = DFLT_SO_LINGER;

/** IP finder clean frequency. */
/**
* The frequency with which coordinator cleans IP finder and keeps it in the correct state, which means that
* coordinator unregisters addresses of the nodes that have left the topology and re-registries missing addresses.
*
* @see org.apache.ignite.spi.discovery.tcp.ServerImpl.IpFinderCleaner
*/
protected long ipFinderCleanFreq = DFLT_IP_FINDER_CLEAN_FREQ;

/** Node authenticator. */
Expand Down Expand Up @@ -865,7 +874,8 @@ public TcpDiscoverySpi setStatisticsPrintFrequency(long statsPrintFreq) {
}

/**
* Gets IP finder clean frequency.
* Gets frequency with which coordinator cleans IP finder and keeps it in the correct state, unregistering addresses of
* the nodes that have left the topology.
*
* @return IP finder clean frequency.
*/
Expand Down Expand Up @@ -987,7 +997,9 @@ public TcpDiscoverySpi setNetworkTimeout(long netTimeout) {
}

/**
* Gets join timeout.
* Get join timeout, in milliseconds. Time to wait for joining. If node cannot connect to any address from the IP
* finder, the node continues to try to join during this timeout. If all addresses still do not respond, an
* exception will occur and the node will fail to start. If 0 is specified, it means wait forever.
*
* @return Join timeout.
*/
Expand Down
14 changes: 10 additions & 4 deletions modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiMBean.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,12 @@ public interface TcpDiscoverySpiMBean extends IgniteSpiManagementMBean, Discover
public int getThreadPriority();

/**
* Gets IP finder clean frequency.
* Gets frequency with which coordinator cleans IP finder and keeps it in the correct state, unregistering addresses
* of the nodes that have left the topology.
*
* @return IP finder clean frequency.
*/
@MXBeanDescription("IP finder clean frequency.")
@MXBeanDescription("The frequency with which coordinator cleans IP finder and keeps it in the correct state, unregistering addresses of the nodes that have left the topology.")
public long getIpFinderCleanFrequency();

/**
Expand Down Expand Up @@ -247,11 +248,16 @@ public interface TcpDiscoverySpiMBean extends IgniteSpiManagementMBean, Discover
public long getSocketTimeout();

/**
* Gets join timeout.
* The join timeout, in milliseconds. Time to wait for joining. If node cannot connect to any address from the IP
* finder, the node continues to try to join during this timeout. If all addresses still do not respond, an
* exception will occur and the node will fail to start. If 0 is specified, it means wait forever.
*
* @return Join timeout.
*/
@MXBeanDescription("Join timeout.")
@MXBeanDescription("The join timeout, in milliseconds. Time to wait for joining. " +
"If node cannot connect to any address from the IP finder, the node continues to try to join during this timeout. " +
"If all addresses still do not respond, an exception will occur and the node will fail to start. " +
"If 0 is specified, it means wait forever.")
public long getJoinTimeout();

/**
Expand Down