Skip to content

Conversation

@nizhikov
Copy link
Contributor

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

@nizhikov
Copy link
Contributor Author

nizhikov commented Feb 1, 2021

Hello, @ptupitsyn

Can you, please, take a look at my changes.
This patch enabled "register same java type" mode for messaging.

DoOutOp((int) Op.SendMulti, writer =>
bool locRegisterSameJavaType = Marshaller.RegisterSameJavaTypeTl.Value;

Marshaller.RegisterSameJavaTypeTl.Value = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on the dev list, this Java type registration behavior can be only enabled when we are calling Java user code. For Compute and Services this can be determined precisely. But for Messaging we don't know whether listeners are in .NET or Java, so this is a compatibility risk.

@nizhikov nizhikov closed this Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants