Skip to content

Conversation

@NSAmelchev
Copy link
Contributor

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

NSAmelchev and others added 2 commits March 30, 2021 13:39
Co-authored-by: Nikita Safonov <73828260+Nikita-tech-writer@users.noreply.github.com>
…adoc

Co-authored-by: Nikita Safonov <73828260+Nikita-tech-writer@users.noreply.github.com>
…adoc

Co-authored-by: Nikita Safonov <73828260+Nikita-tech-writer@users.noreply.github.com>
Copy link
Contributor

@Nikita-tech-writer Nikita-tech-writer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NSAmelchev Please see my suggested changes to the PR.
Just in case: You can commit them directly in the PR.

…adoc

Co-authored-by: Nikita Safonov <73828260+Nikita-tech-writer@users.noreply.github.com>
@NSAmelchev
Copy link
Contributor Author

@NSAmelchev Please see my suggested changes to the PR.
Just in case: You can commit them directly in the PR.

@Nikita-tech-writer Thank you for the review! I have approved your suggestions.

@Nikita-tech-writer
Copy link
Contributor

Nikita-tech-writer commented Mar 30, 2021

@NSAmelchev Please see my suggested changes to the PR.
Just in case: You can commit them directly in the PR.

@Nikita-tech-writer Thank you for the review! I have approved your suggestions.

Great! I'd like to clarify just one thing:

The script seems to work on Windows, doesn't it?

If yes, then it's better to have two separate tabs for Unix and Windows (the ones that I suggested).
Otherwise, the formatting should be as follows:

[source,shell]
----
performance-statistics-tool/print-statistics.sh path_to_files
----

@NSAmelchev
Copy link
Contributor Author

NSAmelchev commented Mar 30, 2021

@NSAmelchev Please see my suggested changes to the PR.
Just in case: You can commit them directly in the PR.

@Nikita-tech-writer Thank you for the review! I have approved your suggestions.

Great! I'd like to clarify just one thing:

The script seems to work on Windows, doesn't it?

If yes, then it's better to have two separate tabs for Unix and Windows (the ones that I suggested).
Otherwise, the formatting should be as follows:

[source,shell]
----
performance-statistics-tool/print-statistics.sh path_to_files
----

@Nikita-tech-writer , No, it doesn't work on Windows. I have fixed tabs.

@Nikita-tech-writer
Copy link
Contributor

@Nikita-tech-writer , No, it doesn't work on Windows. I have fixed tabs.

OK, thanks for your clarification! :)
LGTM!

@NSAmelchev NSAmelchev merged commit 1761294 into apache:master Mar 30, 2021
xintrian pushed a commit to xintrian/ignite that referenced this pull request May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants