IGNITE-14424 #9036
Merged
IGNITE-14424 #9036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtern
force-pushed
the
ignite-14424
branch
2 times, most recently
from
995a42c to
760df2c
Compare
NSAmelchev
approved these changes
May 25, 2021
|
|
||
| /** {@inheritDoc} */ | ||
| @Override public void onDoneAfterTopologyUnlock(GridDhtPartitionsExchangeFuture fut) { | ||
| if (fut.activateCluster() || fut.localJoinExchange()) { |
Contributor
There was a problem hiding this comment.
What if the current node joins an inactive cluster?
Contributor
Author
There was a problem hiding this comment.
If a node joins an inactive cluster, no PME occurs.
| assertTrue(isReencryptionInProgress(Collections.singleton(cacheName()))); | ||
|
|
||
| node0.cluster().state(ClusterState.INACTIVE); | ||
|
|
Contributor
There was a problem hiding this comment.
stopGrid(GRID_1);
startGrid(GRID_1);
Reproduces the problem I've mentioned above
Contributor
Author
There was a problem hiding this comment.
Added this case and fix for it.
(from my point of view, the name of the isReencryptionInProgress method in the test is not entirely correct - this method checks that re-encryption is required, but it doesn’t say whether the re-encryption task is running, I can’t remember why this name was chosen)
alex-plekhanov
approved these changes
Jun 3, 2021
sergeyuttsel
pushed a commit
to gridgain/apache-ignite
that referenced
this pull request
Sep 3, 2021
…econdary activation. (apache#9036)
xintrian
pushed a commit
to xintrian/ignite
that referenced
this pull request
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.