IGNITE-15830 Fix performance suggestion when Ignite is run with a jdk… #9533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… other than 8x When started on Java 11, current Ignite suggests to switch to the latest Java 8 JVM which seems weird as Ignite is officially tested on Java 8 and 11 ( https://ignite.apache.org/docs/latest/quick-start/java ), and the recommended version for running Ignite is 11. This commit changes the behavior to 'Suggest Java 11 when run on any Java version other than 11'.
ibessonov
requested changes
Nov 1, 2021
| public class JvmConfigurationSuggestionsTest { | ||
| /***/ | ||
| @Test | ||
| @WithSystemProperty(key = "java.specification.version", value = "1.8") |
Contributor
There was a problem hiding this comment.
For this annotation to work you should add JUnit rule. But I see that it's not even required, you could just remove annotations.
Contributor
Author
There was a problem hiding this comment.
Good catch, I forgot to remove them. Fixed.
… other than 8x - remove unneeded annotations
ibessonov
approved these changes
Nov 1, 2021
Contributor
Author
|
Thanks for the review! |
xintrian
pushed a commit
to xintrian/ignite
that referenced
this pull request
May 27, 2022
… other than 8x (apache#9533) When started on Java 11, current Ignite suggests to switch to the latest Java 8 JVM which seems weird as Ignite is officially tested on Java 8 and 11 ( https://ignite.apache.org/docs/latest/quick-start/java ), and the recommended version for running Ignite is 11. This commit changes the behavior to 'Suggest Java 11 when run on any Java version other than 11'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… other than 8x
When started on Java 11, current Ignite suggests to switch to the latest Java 8 JVM which seems weird as Ignite is officially tested on Java 8 and 11 ( https://ignite.apache.org/docs/latest/quick-start/java ), and the recommended version for running Ignite is 11.
This commit changes the behavior to 'Suggest Java 11 when run on any Java version other than 11'.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.