Skip to content

Conversation

@AndyDem
Copy link
Contributor

@AndyDem AndyDem commented Nov 16, 2021

IGNITE-15348 Checkstyle checks whitespace after cast token (TYPECAST added to checkstyle.xml), connected issues over the repo are solved according to Ignite code style

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

@AndyDem
Copy link
Contributor Author

AndyDem commented Nov 23, 2021

Hi, @timoninmaxim!
Tests failed due to the fact that there were changes made by other contributors. Said changes didn't follow the code style.
I resolved this issue and PR needs to be approved again, I guess.

@asfgit asfgit closed this in 9021f78 Nov 25, 2021
xintrian pushed a commit to xintrian/ignite that referenced this pull request May 27, 2022
… issues are solved. - Fixes apache#9568.

Signed-off-by: Aleksey Plekhanov <plehanov.alex@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants