Skip to content

Conversation

@Mmuzaf
Copy link
Contributor

@Mmuzaf Mmuzaf commented Dec 2, 2021

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

@Mmuzaf
Copy link
Contributor Author

Mmuzaf commented Dec 2, 2021

@Nikita-tech-writer Can you review the patch?

@Nikita-tech-writer
Copy link
Contributor

@Mmuzaf I've left a couple of suggestions. The rest LGTM! Thank you.

Mmuzaf and others added 2 commits December 3, 2021 13:07
Co-authored-by: Nikita Safonov <73828260+Nikita-tech-writer@users.noreply.github.com>
Co-authored-by: Nikita Safonov <73828260+Nikita-tech-writer@users.noreply.github.com>
@Mmuzaf Mmuzaf merged commit 072b26f into apache:master Dec 3, 2021
Mmuzaf added a commit that referenced this pull request Dec 3, 2021
xintrian pushed a commit to xintrian/ignite that referenced this pull request May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants