-
Notifications
You must be signed in to change notification settings - Fork 1.9k
IGNITE-14913 CacheMetrics command for Control Script #9694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c46bc6e to
99905be
Compare
6b7c4ef to
3ed8a0a
Compare
e4c920c to
7ec677a
Compare
petrov-mg
reviewed
Apr 17, 2022
...java/org/apache/ignite/internal/commandline/cache/argument/CacheMetricsManageCommandArg.java
Outdated
Show resolved
Hide resolved
...java/org/apache/ignite/internal/commandline/cache/argument/CacheMetricsManageCommandArg.java
Outdated
Show resolved
Hide resolved
...l-utility/src/main/java/org/apache/ignite/internal/commandline/cache/CacheMetricsManage.java
Outdated
Show resolved
Hide resolved
...l-utility/src/main/java/org/apache/ignite/internal/commandline/cache/CacheMetricsManage.java
Outdated
Show resolved
Hide resolved
...l-utility/src/main/java/org/apache/ignite/internal/commandline/cache/CacheMetricsManage.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/ignite/internal/visor/cache/metrics/VisorCacheMetricsManageTask.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/ignite/internal/visor/cache/metrics/VisorCacheMetricsManageTask.java
Outdated
Show resolved
Hide resolved
...l-utility/src/main/java/org/apache/ignite/internal/commandline/cache/CacheMetricsManage.java
Outdated
Show resolved
Hide resolved
...ility/src/main/java/org/apache/ignite/internal/commandline/systemview/SystemViewCommand.java
Outdated
Show resolved
Hide resolved
...l-utility/src/main/java/org/apache/ignite/internal/commandline/cache/CacheMetricsManage.java
Outdated
Show resolved
Hide resolved
petrov-mg
approved these changes
May 6, 2022
4036843 to
46205fd
Compare
…GridCommandHandlerClusterByClassWithSSLTest
…s to separate package.
…or serde order in VisorCacheMetricTaskArg
…ricTaskResult, unified table output for all operations
e377e95 to
a65495a
Compare
NSAmelchev
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.
Implementation
Main classes
Internal task
VisorCacheMetricsTaskis implemented for enabling or disabling metrics collection.Logic of Control Script is implemented in
CacheMetricsclass.Command syntax
--cache metrics enable|disable|status --caches cache1[,...,cacheN]|--all-cachesOutput format
Status
Enable/disable
Execution errors
If one of a specified caches was not found, then exception will be thrown:
For
statusoperation:For
enable/disableoperations: