IGNITE-16822 Fix GridCacheLifecycleAwareSelfTest.testLifecycleAware #9955
Conversation
...c/test/java/org/apache/ignite/internal/processors/cache/GridCacheLifecycleAwareSelfTest.java
Show resolved
Hide resolved
| } | ||
|
|
||
| /** {@inheritDoc} */ | ||
| @Override public void start() { |
There was a problem hiding this comment.
AFAIK,
this method works incorrectly - please add assertion assertNotNull(expCacheName).
we don't need this method - we just need to add Serializable marker to TestLifecycleAware.
There was a problem hiding this comment.
public interface EvictionFilter<K, V> extends Serializable {
| } | ||
|
|
||
| /** {@inheritDoc} */ | ||
| @Override public void start() { |
There was a problem hiding this comment.
Same goes here - we don't need this method - we just need to add Serializable marker to TestLifecycleAware.
There was a problem hiding this comment.
public interface CacheInterceptor<K, V> extends Serializable {
There was a problem hiding this comment.
expCacheName is not serialized by default, because supertype is not serializable.
from javadoc (Serializable)
To allow subtypes of non-serializable classes to be serialized, the subtype may assume responsibility for saving and restoring the state of the supertype's public, protected, and (if accessible) package fields. The subtype may assume this responsibility only if the class it extends has an accessible no-arg constructor to initialize the class's state.
There was a problem hiding this comment.
You are correct! Fix changed according to your comments. Good catch. Thanks!
...c/test/java/org/apache/ignite/internal/processors/cache/GridCacheLifecycleAwareSelfTest.java
Show resolved
Hide resolved
2 participants
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.