[AIRFLOW-2909] Deprecate airflow.operators.sensors module

[tedmiston]

Make sure you have checked all steps below.

Jira

• My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
  • https://issues.apache.org/jira/browse/AIRFLOW-2909
  • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.

Description

• Here are some details about my PR, including screenshots of any UI changes:

This PR removes the now deprecated for 2.0 airflow.operators.sensors module and updates all references to its sensors to use the new airflow.sensors.foo_sensor layout.

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:

Deprecated functionality.

Commits

• My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it.
  • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

• Passes git diff upstream/master -u -- "*.py" | flake8 --diff

[tedmiston]

It looks like @Fokko authored and @bolkedebruin committed the new sensors layout backwards compatibility for < 2.0 (6f00f72, 33c7204), so perhaps either / both would be a good reviewer for this PR.

[codecov-io]

Codecov Report

Merging #3760 into master will decrease coverage by 0.29%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #3760     +/-   ##
=========================================
- Coverage   77.67%   77.38%   -0.3%     
=========================================
  Files         204      203      -1     
  Lines       15846    15810     -36     
=========================================
- Hits        12309    12234     -75     
- Misses       3537     3576     +39

Impacted Files	Coverage Δ
airflow/sensors/web_hdfs_sensor.py	0% <0%> (-50%)	⬇️
airflow/sensors/s3_prefix_sensor.py	0% <0%> (-41.18%)	⬇️
airflow/sensors/metastore_partition_sensor.py	0% <0%> (-40%)	⬇️
airflow/sensors/hive_partition_sensor.py	0% <0%> (-36.37%)	⬇️
airflow/sensors/s3_key_sensor.py	0% <0%> (-31.04%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00adade...c389281. Read the comment docs.

[Fokko]

Thanks @tedmiston for picking this up, could you remove these references as well?

MacBook-Pro-van-Fokko:incubator-airflow fokkodriesprong$ grep -R "airflow.operators.sensors" .
grep: ./airflow/www/static/docs: No such file or directory
grep: ./airflow/www_rbac/static/docs: No such file or directory
./build/lib/airflow/contrib/sensors/sftp_sensor.py:from airflow.operators.sensors import BaseSensorOperator
./build/lib/airflow/contrib/sensors/hdfs_sensors.py:from airflow.operators.sensors import HdfsSensor
./build/lib/airflow/contrib/operators/fs_operator.py:from airflow.operators.sensors import BaseSensorOperator

[tedmiston]

@Fokko Sure, I just checked and I do not have this build directory in my incubator-airflow. Is it possible that those files you're seeing locally are cached from a setuptools build or something?

[feng-tao]

lgtm. @Fokko , I think those are from your local build dir. I can't find those in my repo.

[Fokko]

@tedmiston @feng-tao Oops, yes, this is some old build stuff dangling around in my airflow folder. Are we going to do 1.10.1 or directly to 2.0.0?

[tedmiston]

I'm hoping straight to 2.0 as I've already had 1 PR merged that fully deprecates a "this will be deprecated soon" type feature (#3695). In either case, I suppose we have a trunk for 1.10 now. On the Jira issue, I've marked this as ≥ 2.0.

fix

[Fokko]

Makes sense @tedmiston Thanks!

[Fokko]

@tedmiston We still missed this one: https://github.com/apache/incubator-airflow/pull/3808/files