[BEAM-498] Remove some more uses of OldDoFn#1178
Closed
kennknowles wants to merge 3 commits intoapache:masterfrom
Closed
[BEAM-498] Remove some more uses of OldDoFn#1178kennknowles wants to merge 3 commits intoapache:masterfrom
kennknowles wants to merge 3 commits intoapache:masterfrom
Conversation
Member
Author
|
Feel free to leave this review lower priority and I will port a bunch more |
kennknowles
force-pushed
the
ValueWithRecordId
branch
from
4219bb5 to
4ca523d
Compare
Member
Author
|
OK, this is ready for review. I have removed all non-essential uses of |
Member
|
The only essential use is |
Member
Author
|
That is correct. There is exactly one use. |
tgroh
approved these changes
Oct 25, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
R: @tgroh
In the DirectRunner tests, I ported the syntax, though not the logic since it doesn't actually run yet. I'm not totally certain these tests are needed beyond future ROS tests.