Skip to content

[BEAM-498] Moves OldDoFn to runners-core#1636

Merged
asfgit merged 2 commits intoapache:masterfrom
jkff:move-old-do-fn
Jan 20, 2017
Merged

[BEAM-498] Moves OldDoFn to runners-core#1636
asfgit merged 2 commits intoapache:masterfrom
jkff:move-old-do-fn

Conversation

@jkff
Copy link
Copy Markdown
Contributor

@jkff jkff commented Dec 16, 2016

This will of course need the usual Dataflow worker surgery.

R: @kennknowles

@asfbot
Copy link
Copy Markdown

asfbot commented Dec 16, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/5981/

Build result: ABORTED

[...truncated 12985 lines...] ... 31 moreCaused by: java.lang.RuntimeException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?Command was /bin/sh -c cd /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/examples/java && /usr/local/asfpackages/java/jdk1.8.0_102/jre/bin/java '-javaagent:/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/.repository/org/jacoco/org.jacoco.agent/0.7.5.201505241946/org.jacoco.agent-0.7.5.201505241946-runtime.jar=destfile=/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/examples/java/target/jacoco.exec,excludes=**/AutoValue_*.class,dumponexit=true,output=file' org.apache.maven.surefire.booter.ForkedBooter /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/examples/java/target/surefire/surefire7738274749691766430tmp /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/examples/java/target/surefire/surefire_36934452473276356226tmp at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:590) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:460) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:229) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:201) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1026) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:862) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:755) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) ... 32 more[ERROR] [ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :beam-examples-javaBuild was abortedchannel stoppedSetting status of 374a450 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/5981/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@kennknowles
Copy link
Copy Markdown
Member

retest this please

@kennknowles
Copy link
Copy Markdown
Member

LGTM. Just kicked Jenkins to double check that the failures are just the expected.

@asfbot
Copy link
Copy Markdown

asfbot commented Dec 16, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/5987/

Build result: ABORTED

[...truncated 12880 lines...][INFO] --- maven-failsafe-plugin:2.19.1:integration-test (dataflow-runner-integration-tests) @ beam-examples-java ---[INFO] Failsafe report directory: /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/examples/java/target/failsafe-reports[INFO] parallel='all', perCoreThreadCount=true, threadCount=4, useUnlimitedThreads=false, threadCountSuites=0, threadCountClasses=0, threadCountMethods=0, parallelOptimized=true------------------------------------------------------- T E S T S-------------------------------------------------------SLF4J: Class path contains multiple SLF4J bindings.SLF4J: Found binding in [jar:file:/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/.repository/org/slf4j/slf4j-jdk14/1.7.14/slf4j-jdk14-1.7.14.jar!/org/slf4j/impl/StaticLoggerBinder.class]SLF4J: Found binding in [jar:file:/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/.repository/org/slf4j/slf4j-log4j12/1.7.10/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.SLF4J: Actual binding is of type [org.slf4j.impl.JDK14LoggerFactory]Build timed out (after 100 minutes). Marking the build as aborted.Results :Tests run: 0, Failures: 0, Errors: 0, Skipped: 0Build was aborted[WARNING] Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy: Invalid object ID 9 iota=41channel stopped[WARNING] Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy: hudson.remoting.Channel$OrderlyShutdownSetting status of 374a450 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/5987/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@kennknowles
Copy link
Copy Markdown
Member

The build is being aborted after the time limit in the Dataflow integration tests. Presumably due to an infinite retry? I will not kick it again until we have a worker for this PR.

@kennknowles
Copy link
Copy Markdown
Member

I believe the reverts in #1648 would go well in this PR and could accomplish the goal in the PR title. I would be very interested in a cherry-pick of a22de15, f3e8a03, and 33ed323 to this branch.

@asfbot
Copy link
Copy Markdown

asfbot commented Jan 18, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/6606/

Build result: FAILURE

[...truncated 6390 lines...] at hudson.remoting.UserRequest.perform(UserRequest.java:153) at hudson.remoting.UserRequest.perform(UserRequest.java:50) at hudson.remoting.Request$2.run(Request.java:332) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745)Caused by: org.apache.maven.plugin.MojoExecutionException: Dependency problems found at org.apache.maven.plugin.dependency.analyze.AbstractAnalyzeMojo.execute(AbstractAnalyzeMojo.java:260) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 31 more2017-01-18T00:43:25.562 [ERROR] 2017-01-18T00:43:25.562 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-01-18T00:43:25.562 [ERROR] 2017-01-18T00:43:25.562 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-01-18T00:43:25.562 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException2017-01-18T00:43:25.563 [ERROR] 2017-01-18T00:43:25.563 [ERROR] After correcting the problems, you can resume the build with the command2017-01-18T00:43:25.563 [ERROR] mvn -rf :beam-runners-google-cloud-dataflow-javachannel stoppedSetting status of 87b4736 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/6606/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@jkff jkff force-pushed the move-old-do-fn branch 2 times, most recently from c2577d6 to e890fdd Compare January 20, 2017 02:17
@asfbot
Copy link
Copy Markdown

asfbot commented Jan 20, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/6672/

Build result: FAILURE

[...truncated 6400 lines...] at hudson.remoting.UserRequest.perform(UserRequest.java:153) at hudson.remoting.UserRequest.perform(UserRequest.java:50) at hudson.remoting.Request$2.run(Request.java:332) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745)Caused by: org.apache.maven.plugin.MojoExecutionException: Dependency problems found at org.apache.maven.plugin.dependency.analyze.AbstractAnalyzeMojo.execute(AbstractAnalyzeMojo.java:260) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 31 more2017-01-20T02:25:20.364 [ERROR] 2017-01-20T02:25:20.364 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-01-20T02:25:20.364 [ERROR] 2017-01-20T02:25:20.364 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-01-20T02:25:20.364 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException2017-01-20T02:25:20.364 [ERROR] 2017-01-20T02:25:20.364 [ERROR] After correcting the problems, you can resume the build with the command2017-01-20T02:25:20.364 [ERROR] mvn -rf :beam-runners-google-cloud-dataflow-javachannel stoppedSetting status of c2577d6 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/6672/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@asfbot
Copy link
Copy Markdown

asfbot commented Jan 20, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/6673/
--none--

@asfbot
Copy link
Copy Markdown

asfbot commented Jan 20, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/6674/

Build result: ABORTED

[...truncated 13444 lines...]2017-01-20T04:26:42.130 [INFO] Apache Beam :: SDKs :: Java :: Maven Archetypes :: Starter SUCCESS [ 14.089 s]2017-01-20T04:26:42.130 [INFO] Apache Beam :: SDKs :: Java :: Maven Archetypes :: Examples SUCCESS [ 14.178 s]2017-01-20T04:26:42.130 [INFO] Apache Beam :: SDKs :: Java :: Maven Archetypes :: Examples - Java 8 SUCCESS [ 17.513 s]2017-01-20T04:26:42.130 [INFO] Apache Beam :: SDKs :: Java :: Extensions .......... SUCCESS [ 1.797 s]2017-01-20T04:26:42.130 [INFO] Apache Beam :: SDKs :: Java :: Extensions :: Join library SUCCESS [ 10.850 s]2017-01-20T04:26:42.130 [INFO] Apache Beam :: SDKs :: Java :: Extensions :: Sorter SUCCESS [ 25.095 s]2017-01-20T04:26:42.130 [INFO] Apache Beam :: SDKs :: Java :: Java 8 Tests ........ SUCCESS [ 8.315 s]2017-01-20T04:26:42.130 [INFO] Apache Beam :: Runners :: Flink .................... SUCCESS [ 1.201 s]2017-01-20T04:26:42.130 [INFO] Apache Beam :: Runners :: Flink :: Core ............ SUCCESS [ 28.693 s]2017-01-20T04:26:42.130 [INFO] Apache Beam :: Runners :: Flink :: Examples ........ SUCCESS [ 11.988 s]2017-01-20T04:26:42.130 [INFO] Apache Beam :: Runners :: Spark .................... SUCCESS [03:12 min]2017-01-20T04:26:42.130 [INFO] Apache Beam :: Runners :: Apex ..................... SUCCESS [ 56.115 s]2017-01-20T04:26:42.130 [INFO] Apache Beam :: Examples ............................ SUCCESS [ 2.341 s]2017-01-20T04:26:42.130 [INFO] Apache Beam :: Examples :: Java .................... FAILURE [ 01:19 h]2017-01-20T04:26:42.130 [INFO] Apache Beam :: Examples :: Java 8 .................. SKIPPED2017-01-20T04:26:42.130 [INFO] ------------------------------------------------------------------------2017-01-20T04:26:42.130 [INFO] BUILD FAILURE2017-01-20T04:26:42.130 [INFO] ------------------------------------------------------------------------2017-01-20T04:26:42.130 [INFO] Total time: 01:39 h2017-01-20T04:26:42.131 [INFO] Finished at: 2017-01-20T04:26:42+00:002017-01-20T04:26:43.410 [INFO] Final Memory: 165M/1847M2017-01-20T04:26:43.413 [INFO] ------------------------------------------------------------------------Setting status of c8699f7 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/6674/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@kennknowles
Copy link
Copy Markdown
Member

I think you can proceed with the worker image.

@kennknowles
Copy link
Copy Markdown
Member

kennknowles commented Jan 20, 2017

@kennknowles
Copy link
Copy Markdown
Member

But since the worker image built, I think the precommit as a smoke test is adequate.

@asfbot
Copy link
Copy Markdown

asfbot commented Jan 20, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/6702/
--none--

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.01%) to 69.841% when pulling a2b94ec on jkff:move-old-do-fn into 77c7505 on apache:master.

@asfbot
Copy link
Copy Markdown

asfbot commented Jan 20, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/6703/
--none--

@kennknowles
Copy link
Copy Markdown
Member

LGTM. I'll merge since it is easy to detect a failure and revert.

@asfgit asfgit merged commit a2b94ec into apache:master Jan 20, 2017
asfgit pushed a commit that referenced this pull request Jan 20, 2017
  Point to new Dataflow worker
  Moves OldDoFn to runners-core
@jkff jkff deleted the move-old-do-fn branch January 20, 2017 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants