[BEAM-77] Create runners/core module for artifact org.apache.beam:runners-core#281
Merged
asfgit merged 2 commits intoapache:masterfrom May 4, 2016
Merged
[BEAM-77] Create runners/core module for artifact org.apache.beam:runners-core#281asfgit merged 2 commits intoapache:masterfrom
asfgit merged 2 commits intoapache:masterfrom
Conversation
kennknowles
force-pushed
the
runners-core
branch
3 times, most recently
from
d9caf02 to
ee8a9ce
Compare
Member
Author
|
I haven't worked too hard at the |
kennknowles
force-pushed
the
runners-core
branch
3 times, most recently
from
71d9c85 to
7005dc1
Compare
runners/core-java/pom.xml
Outdated
|
|
||
| <artifactId>runners-core</artifactId> | ||
| <name>Apache Beam :: Runners :: Core</name> | ||
| <description> |
Member
Author
There was a problem hiding this comment.
Does that matter? The formatting gets bad.
Member
Author
There was a problem hiding this comment.
Nevermind; short enough for one line.
kennknowles
force-pushed
the
runners-core
branch
3 times, most recently
from
984658c to
2221c5e
Compare
Member
Author
|
Please take another look when you get a chance. The two commits are independent, not to be squashed. |
runners/core-java/pom.xml
Outdated
| <dependency> | ||
| <groupId>junit</groupId> | ||
| <artifactId>junit</artifactId> | ||
| <scope>provided</scope> |
Member
|
LGTM, modulo resolution of pending comments. (I probably don't need to take another look, unless there's something contentious.) |
kennknowles
changed the title
This is strictly creating the module and moving one easy class to it. Many of the utilities in org.apache.beam.util and subpackages should move as developments allow.
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
mareksimunek
added a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
Vasek/beam rt rebase
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
This is strictly creating the module and moving one easy class to it.
Many of the utilities in org.apache.beam.util and subpackages should
move as developments allow.