[BEAM-289] Examples Use TypeDescriptors#342
Closed
eljefe6a wants to merge 35 commits intoapache:masterfrom
Closed
Conversation
…rst. Fixed some JavaDocs.
We have started picking up snapshot versions of the next version of Kafka, which cause build breaks. Pin to 0.9.0.1 which is the version we've been building with successfully.
Contributor
Author
|
The build succeeded, but Jenkins timed out. cc @kennknowles |
Removing an extra '-' in the comment XML prefix "!<---". This is not a valid prefix and breaks Maven release plugin.
Explicitly disble Javadoc generation phase. This phase runs during the release process, but the current codebase doesn't compile Javadoc. This should be fixed and removed as soon as possible.
Disable Javadoc execution, which runs in the release profile, because it is currently broken and blocks release.
Misuse of Javadoc caused a bad import.
Member
|
R: @kennknowles I'm taking a look. One way you can kick Jenkins is to rebase against the current HEAD. |
Member
|
Any chance you can prune the other commits out of this pull request? |
…rst. Fixed some JavaDocs.
…/incubator-beam into TypeDescriptorsExamples
Contributor
Author
|
Closing to use a different branch without the extra commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira issue BEAM-289 Examples Use TypeDescriptors. Changed example code to use
TypeDescriptors.These could have used static imports to make the lines shorter, but we opted for the more understandable syntax.