Skip to content

[BEAM-211] Replace usages of PCollection.setCoder with Create.of().withCoder #378

Closed
ilganeli wants to merge 3 commits intoapache:masterfrom
ilganeli:BEAM-211
Closed

[BEAM-211] Replace usages of PCollection.setCoder with Create.of().withCoder #378
ilganeli wants to merge 3 commits intoapache:masterfrom
ilganeli:BEAM-211

Conversation

@ilganeli
Copy link

  • Replaced all usages of PCollection.setCoder`` with the recommendedwithCoder```.

@ilganeli
Copy link
Author

Retest this please

@ilganeli
Copy link
Author

Looks like the Jenkins failure is due exclusively to a connection failure when pulling Flink dependencies.

@kennknowles
Copy link
Member

LGTM. Thanks!

@asfgit asfgit closed this in 8ff800b May 24, 2016
@amitsela
Copy link
Member

I actually opened [BEAM-211] as a runner-spark issue since this appears all over the runner's unit tests..
I actually didn't think we had this issue in the SDK as well.
I'll reopen as a new JIRA and be more specific.
Thanks for the contribution @ilganeli and feel free to checkout the same issue in the Spark runner 😃

@ilganeli
Copy link
Author

ilganeli commented May 24, 2016

@amitsela This brings up an interesting point. If an issue is specific to the Spark Runner, which is maintained as a separate project, is that still tracked within Beam? Is this a non-issue since all the runners are now subsumed by and maintained within Beam?

tvalentyn pushed a commit to tvalentyn/beam that referenced this pull request May 15, 2018
pl04351820 pushed a commit to pl04351820/beam that referenced this pull request Dec 20, 2023
…e#1083) (apache#378)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [pre-commit/pre-commit-hooks](https://togithub.com/pre-commit/pre-commit-hooks) | repository | major | `v3.4.0` -> `v4.0.1` |

---

### Release Notes

<details>
<summary>pre-commit/pre-commit-hooks</summary>

### [`v4.0.1`](https://togithub.com/pre-commit/pre-commit-hooks/releases/v4.0.1)

[Compare Source](https://togithub.com/pre-commit/pre-commit-hooks/compare/v4.0.0...v4.0.1)

##### Fixes

-   `check-shebang-scripts-are-executable` fix entry point.
    -   [#&apache#8203;602](https://togithub.com/pre-commit/pre-commit-hooks/issues/602) issue by [@&apache#8203;Person-93](https://togithub.com/Person-93).
    -   [#&apache#8203;603](https://togithub.com/pre-commit/pre-commit-hooks/issues/603) PR by [@&apache#8203;scop](https://togithub.com/scop).

### [`v4.0.0`](https://togithub.com/pre-commit/pre-commit-hooks/releases/v4.0.0)

[Compare Source](https://togithub.com/pre-commit/pre-commit-hooks/compare/v3.4.0...v4.0.0)

##### Features

-   `check-json`: report duplicate keys.
    -   [#&apache#8203;558](https://togithub.com/pre-commit/pre-commit-hooks/issues/558) PR by [@&apache#8203;AdityaKhursale](https://togithub.com/AdityaKhursale).
    -   [#&apache#8203;554](https://togithub.com/pre-commit/pre-commit-hooks/issues/554) issue by [@&apache#8203;adamchainz](https://togithub.com/adamchainz).
-   `no-commit-to-branch`: add `main` to default blocked branches.
    -   [#&apache#8203;565](https://togithub.com/pre-commit/pre-commit-hooks/issues/565) PR by [@&apache#8203;ndevenish](https://togithub.com/ndevenish).
-   `check-case-conflict`: check conflicts in directory names as well.
    -   [#&apache#8203;575](https://togithub.com/pre-commit/pre-commit-hooks/issues/575) PR by [@&apache#8203;slsyy](https://togithub.com/slsyy).
    -   [#&apache#8203;70](https://togithub.com/pre-commit/pre-commit-hooks/issues/70) issue by [@&apache#8203;andyjack](https://togithub.com/andyjack).
-   `check-vcs-permalinks`: forbid other branch names.
    -   [#&apache#8203;582](https://togithub.com/pre-commit/pre-commit-hooks/issues/582) PR by [@&apache#8203;jack1142](https://togithub.com/jack1142).
    -   [#&apache#8203;581](https://togithub.com/pre-commit/pre-commit-hooks/issues/581) issue by [@&apache#8203;jack1142](https://togithub.com/jack1142).
-   `check-shebang-scripts-are-executable`: new hook which ensures shebang'd scripts are executable.
    -   [#&apache#8203;545](https://togithub.com/pre-commit/pre-commit-hooks/issues/545) PR by [@&apache#8203;scop](https://togithub.com/scop).

##### Fixes

-   `check-executables-have-shebangs`: Short circuit shebang lookup on windows.
    -   [#&apache#8203;544](https://togithub.com/pre-commit/pre-commit-hooks/issues/544) PR by [@&apache#8203;scop](https://togithub.com/scop).
-   `requirements-txt-fixer`: Fix comments which have indentation
    -   [#&apache#8203;549](https://togithub.com/pre-commit/pre-commit-hooks/issues/549) PR by [@&apache#8203;greshilov](https://togithub.com/greshilov).
    -   [#&apache#8203;548](https://togithub.com/pre-commit/pre-commit-hooks/issues/548) issue by [@&apache#8203;greshilov](https://togithub.com/greshilov).
-   `pretty-format-json`: write to stdout using UTF-8 encoding.
    -   [#&apache#8203;571](https://togithub.com/pre-commit/pre-commit-hooks/issues/571) PR by [@&apache#8203;jack1142](https://togithub.com/jack1142).
    -   [#&apache#8203;570](https://togithub.com/pre-commit/pre-commit-hooks/issues/570) issue by [@&apache#8203;jack1142](https://togithub.com/jack1142).
-   Use more inclusive language.
    -   [#&apache#8203;599](https://togithub.com/pre-commit/pre-commit-hooks/issues/599) PR by [@&apache#8203;asottile](https://togithub.com/asottile).

##### Breaking changes

-   Remove deprecated hooks: `flake8`, `pyflakes`, `autopep8-wrapper`.
    -   [#&apache#8203;597](https://togithub.com/pre-commit/pre-commit-hooks/issues/597) PR by [@&apache#8203;asottile](https://togithub.com/asottile).

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻️ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/synthtool).
Source-Link: googleapis/synthtool@333fd90
Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:b8c131c558606d3cea6e18f8e87befbd448c1482319b0db3c5d5388fa6ea72e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants