[BEAM-88][WIP] DataflowPipelineOptions.tempLocation doesn't really default to stagingLocation

[ilganeli]

This is still a work in progress since it's unclear where the default settings should actually be set. However, I've started by adding a unit test that demonstrates the issue, showing that we violate the assumption that one path is set by default.

[peihe]

R: @peihe

Hi Ilya,
The default value is set in here by DataflowPipelineRunner:
https://github.com/apache/incubator-beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineRunner.java#L273

Also, I am in the progress of changing this behavior. tempLocation has been lifted to PipelineOptions, and became a general concept (not limited to Dataflow). I am changing it not to default to stagingLocation (a Dataflow options).

[kennknowles]

Sorry for being nosy, just browsing PRs. Is #438 the change referred to here?

[dhalperi]

With all the new changes to PipelineOptions, this is actually the intended behavior.

Please close PR at your convenience.

[dhalperi]

Of course, you can also respond here, on BEAM-88, or on Beam mailing list with new comments on updated behavior.