[BEAM-330] Port cleanupDaemonThreads fix to archetype module#444
[BEAM-330] Port cleanupDaemonThreads fix to archetype module#444swegner wants to merge 7 commits intoapache:masterfrom
Conversation
|
R: @dhalperi |
|
Don't we also want this in the starter module in addition to the examples module? |
| </plugin> | ||
| </plugins> | ||
|
|
||
| <pluginManagement> |
There was a problem hiding this comment.
This is what I expect is the minimal configuration needed from the parent pom.xml. I'm not familiar with archetype projects; @dhalperi, do you know how to test that this works?
There was a problem hiding this comment.
Looks like there is enough testing that this already failed. So that's good news. To fix the issue that showed up, you'll need another layer of <plugins></plugins> between <pluginManagement> and <plugin>.
|
Ok, this is finally working. @lukecwik PTAL Verified by locally changing the Beam pom.xml versions from 0.1-incubating-SNAPSHOT to 0.1-incubating, installing, and running the following commands: mvn archetype:generate -DarchetypeGroupId=org.apache.beam -DarchetypeArtifactId=beam-sdks-java-maven-archetypes-examples -DgroupId=com.example -DartifactId=second-dataflow -Dversion="[1.0.0,2.0.0)" -DinteractiveMode=false mvn compile exec:java |
| # | ||
| package=it.pkg | ||
| version=0.1-SNAPSHOT | ||
| version=0.1 |
There was a problem hiding this comment.
why this change? I think SNAPSHOT should be there.
But maybe it should be 0.2-SNAPSHOT?
There was a problem hiding this comment.
This is the template pom.xml that will become part of the user's project, and thus should be separate from the versioning of Beam. The versioning for the user project is somewhat arbitrary, but it should represent "the first version for a new project", so 0.1 makes sense to me.
At any rate, we don't need this change coupled to this bug fix. I'll remove it here and file a separate bug.
There was a problem hiding this comment.
|
@lukecwik PTAL; I believe this should be ready to go in once Jenkin goes green |
swegner
force-pushed
the
mvnexec-archetypes
branch
from
fd1756a to
52496d2
Compare
|
LGTM, will merge after checks go green |
|
Backport: GoogleCloudPlatform/DataflowJavaSDK#302 |
Remove RunnableOnService with tests with ExpectedException
) * removed goToContextLine * PG analytics refactoring (#24901) (#24924): AnalyticsEvent and AnalyticsService in PGC, feedback split, GetIt instead of Provider * AnalyticsCategories, AnalyticsEvents (#24924) * comment fixes (#24924) * renamed playground demo widget (#24924) * tob analytics, generic analytics, events, categories (#24924) * deleted GenericAnalyticsService (#24924) * trackRunExample usage (#24924) * added events (#24924) * new pubspec.lock (#24924) * open and complete unit event implementations (#24924) * time spent in unit on close (#24924) * on before load to track time on close (#24924) * _onTabClosed (#24924) * comment fixes (#24924) * comment fixes (#24924) * made test tasks work (#24924) * Use Google Analytics 4 JS in Playground (#24924) * Update staging URLs and Google Analytics property ID (#24924) * Fix Playground integation tests (#24924) * Disable old Tour of Beam analytics (#24924) * Clean up (#24924) * Fix notifying when window closes (#24924) * Submit page layout to analytics (#24924) * Address review comments (#24924) * Upgrade Flutter to 3.7.2 (#24924) * Upgrade integration tests to Flutter 3.7.3 * Clean up (#24924) * Use the production Google Analytics property, rename event parameters (#24924) * Add LoadedAnalyticsEvent (#24924) * Fix (#24924) * [Tour of Beam] [Frontend] Tour of Beam Analytics (#431) * tob event context (#25466) * flutter v3.7.3 upgrade (#25466) * BeamRunShortcut (#25466) * comment fixes (#25466) * tob app name for analytics parameter (#25466) * comment fixes (#25466) * the rest of tob events except for example modified (#25466) * questioned print (#25466) * additionalParams in SnippetModifiedAnalyticsEvent (#25466) * comment fixes & renamed events to past tense (#25466) * comment fixes (#25466) * reportIssueClicked (#25466) * sort BeamAnalyticsEvents (#25466) --------- Co-authored-by: darkhan.nausharipov <darkhan.nausharipov@kzn.akvelon.com> * Fix Run hot key (#24924) * Address review comments (#24924) * Added comments (#24924) * Added comments (#24924) * Add comments (#24924) * Fix SDK switching (#24924) * Fix integration tests (#24924) * Test analytics events for feedback, report issue, and external url navigation (#24924) (#444) * Test analytics events for feedback, report issue, and external url navigation (#24924) * Test for run_started, run_finished, run_cancelled, loaded, sdk_selected, snippet_selected events (#24924) * Fix a run test (#24924) * Fix a test (#24924) * Fix a test (#24924) * Test for theme_set, new_example, and shortcuts analytics events (#24924) * Test code sharing (#24924) * Test for snippet_modified and snippet_reset events (#24924) * Clean up (#24924) * Clean up (#24924) * Fix tests (#24924) * Differentiate production and dev analytics (#24924) --------- Co-authored-by: darkhan.nausharipov <darkhan.nausharipov@kzn.akvelon.com> Co-authored-by: Alexey Inkin <alexey.inkin@akvelon.com> Co-authored-by: alexeyinkin <leha@inkin.ru>
* chore: reference main branch of google-cloud-python * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update README.rst Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
4 participants
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.