[BEAM-498] Remove WindowingInternals support from DoFnReflector#807
Merged
asfgit merged 1 commit intoapache:masterfrom Aug 10, 2016
Merged
[BEAM-498] Remove WindowingInternals support from DoFnReflector#807asfgit merged 1 commit intoapache:masterfrom
asfgit merged 1 commit intoapache:masterfrom
Conversation
| final TypeToken<?> in, final TypeToken<?> out) { | ||
| return FluentIterable | ||
| .from(extraProcessContexts.values()) | ||
| .filter(new Predicate<AdditionalParameter>() { |
Contributor
There was a problem hiding this comment.
May be easier to do ".remove(InputProvider)" but this is also more future proof. Maybe "isHidden" (to support future parameters not showing up in docs)?
kennknowles
force-pushed
the
DoFn-WindowingInternals
branch
from
9c9bb05 to
2aa0d96
Compare
Contributor
|
LGTM |
The test themselves are replaced by mostly-hidden placeholders, to ensure that our code for handling generic parameters remains in place until new context parameters that use generics are added back.
kennknowles
force-pushed
the
DoFn-WindowingInternals
branch
from
25f8e56 to
20208d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
The test themselves are replaced by mostly-hidden placeholders, to ensure that our code for handling generic parameters remains in place until new context parameters that use generics are added back.
R: @bjchambers since
ExtraContextFactoryis a public interface, currently the hiding is a bit hackish. Probably we can and should refactor it a bit anyhow, but how about this for short term prevention of abuse?