[Bug] [config-ui] Only trigger connection test when multi tokens

[likyh]

Search before asking

• I had searched in the issues and found no similar issues.

What happened

What you expected to happen

Trigger connection test whenever saving connections.

How to reproduce

1. save a GitHub connection when only using 1 token;
2. save the same connection with 2 tokens.
3. Look at the difference between these.

Anything else

No response

Version

main

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[e2corporation]

@klesh @likyh We'll need more clarity on this. There was a feature request already added that if user has multiple tokens on a GitHub or JIRA type connection that a test connection should be run to identify if one of those tokens may not be valid, in which case we want an error to be raised.

What is the exact issue? It appears that the backend should understand that this value is a multi-token string and act accordingly (previously the error shown indicated a bad token). Or does UI need to send the multi-token value as an array and not string? We'll have to inspect the request payload to see what is being sent. If you were saving a connection where both tokens were valid, ideally no error would have been raised and the connection would have been saved.

Here is the original PR to add test connection for a multi-token provider.
#1777

[e2corporation]

Alternatively do we want to allow the user to save even if a token fails authentication?

[klesh]

@e2corporation I feel like this issue has been brought up many times, I used to believe it is better to separate Save and Test, but seems like most people prefer Test & Save. So, maybe we can do that? the connection can be saved IFF Test succeeded.

[e2corporation]

@klesh I think it's overkill to perform test+save in one routine and promotes lazy behavior from our users, the Test button is right there and very accessible. It also will make QA and automated test flows problematic, because then you'll have to enter real/valid credentials before being allowed to save a record. This could also be seen as saving a connection with parameters/credentials that aren't working presently, but will work at a later time. The main connection list table also has a "Status/Online" column which should display the status after connections are (automatically) tested.

[e2corporation]

It may even be more practical to test onChange so when all credentials are completed, run a test and display failure, but still allow the user to save the record.

[likyh]

I think it's ok that test and save in one process. But should return when successful directly. Actually, it just cost 200ms for these 2 actions but wait for 1.8s.

[klesh]

Will be addressed by New ConfigUI flow