[Bug][Github Graphql] Endpoint missing "/" breaks client connection

[keon94]

Search before asking

• I had searched in the issues and found no similar issues.

What happened

incubator-devlake/backend/plugins/github_graphql/impl/impl.go

Line 165 in 7bb73a9

client := graphql.NewClient(connection.Endpoint+`graphql`, httpClient)

uses a simple concactenation of endpoint and "graphql", but assumes the endpoint ends with a slash. This breaks the client and the subtasks will fail.

What do you expect to happen

The code should use url.JoinPath(x,y) to defend against this case.

How to reproduce

Use "https://api.github.com" as the endpoint and hit the graphql plugin directly.

Anything else

No response

Version

main

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct