Skip to content

Unit test for api_extractor#1898

Merged
klesh merged 5 commits intoapache:mainfrom
merico-ai:unit-test
May 19, 2022
Merged

Unit test for api_extractor#1898
klesh merged 5 commits intoapache:mainfrom
merico-ai:unit-test

Conversation

@mappjzc
Copy link
Contributor

@mappjzc mappjzc commented May 17, 2022

Summary

unit test for api_extractor

Key Points

  • This is a breaking change
  • New or existing documentation is updated

Description

unit test for batch_save
unit test for batch_save_divider
fix: delete jira connect without decrypt

Does this close any open issues?

close #1824
close #1843
close #1851
close #1853

Current Behavior

Describe the current behaviour of this issue, if relevant.

New Behavior

Describe the new behaviour updated in this issue, if relevant.

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@mappjzc mappjzc force-pushed the unit-test branch 2 times, most recently from aefb30c to 19239cf Compare May 18, 2022 13:45
Copy link
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mappjzc added 5 commits May 19, 2022 11:38
Delete jira connect without read it from db anymore,
so we don't need to decrypt it anymore.

Nddtfjiang <zhicheng.jiang@merico.dev>
TestBatchSaveDivider

Nddtfjiang <zhicheng.jiang@merico.dev>
TestBatchSave

Nddtfjiang <zhicheng.jiang@merico.dev>
TestApiExtractorExecute
TestApiExtractorExecute_Cancel

Nddtfjiang <zhicheng.jiang@merico.dev>
fix db delete name for jira connection.

Nddtfjiang <zhicheng.jiang@merico.dev>
@klesh klesh merged commit 4293768 into apache:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants